Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 2844373003: [Home] Reduce bottom control container height (Closed)

Created:
3 years, 7 months ago by Theresa
Modified:
3 years, 7 months ago
Reviewers:
mdjones, Ted C
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Home] Reduce bottom control container height BUG=716149 Review-Url: https://codereview.chromium.org/2844373003 Cr-Commit-Position: refs/heads/master@{#468026} Committed: https://chromium.googlesource.com/chromium/src/+/91d96fbdff12d8751743e7b51df93afeeb33c823

Patch Set 1 #

Patch Set 2 : Fix app menu positioning #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -8 lines) Patch
M chrome/android/java/res/values/dimens.xml View 3 chunks +8 lines, -6 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java View 1 1 chunk +1 line, -1 line 1 comment Download
M chrome/android/java/src/org/chromium/chrome/browser/toolbar/BottomToolbarPhone.java View 2 chunks +7 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarPhone.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (11 generated)
Theresa
ptal - screenshot in the bug
3 years, 7 months ago (2017-04-27 23:05:13 UTC) #4
mdjones
lgtm
3 years, 7 months ago (2017-04-28 15:38:25 UTC) #7
Theresa
+tedchoc@ for OWNERS https://codereview.chromium.org/2844373003/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java File chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java (right): https://codereview.chromium.org/2844373003/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java#newcode281 chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java:281: return (mTempLocation[1] + anchorView.getHeight()) >= visibleDisplayFrame.bottom; ...
3 years, 7 months ago (2017-04-28 15:40:10 UTC) #9
Ted C
lgtm
3 years, 7 months ago (2017-04-28 16:44:27 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2844373003/20001
3 years, 7 months ago (2017-04-28 16:45:11 UTC) #14
commit-bot: I haz the power
3 years, 7 months ago (2017-04-28 16:51:11 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/91d96fbdff12d8751743e7b51df9...

Powered by Google App Engine
This is Rietveld 408576698