chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java - Issue 2844373003: [Home] Reduce bottom control container height

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java

Issue 2844373003: [Home] Reduce bottom control container height (Closed)

Patch Set: Fix app menu positioning Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/res/values/dimens.xml ('k') | chrome/android/java/src/org/chromium/chrome/browser/toolbar/BottomToolbarPhone.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java b/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java

index 7de210cf3f43503abb5aa932f1c04f76ff3c9744..00c02a3985af066c0c1c163ce0cfad12e864be71 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java

@@ -278,7 +278,7 @@ public class AppMenu implements OnItemClickListener, OnKeyListener {

private boolean isAnchorAtBottom(View anchorView, Rect visibleDisplayFrame) {

anchorView.getLocationOnScreen(mTempLocation);

- return (mTempLocation[1] + anchorView.getHeight()) == visibleDisplayFrame.bottom;

+ return (mTempLocation[1] + anchorView.getHeight()) >= visibleDisplayFrame.bottom;

Theresa 2017/04/28 15:40:10 The anchor view height + location on screen is now

}

private void setPopupOffset(