Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1273)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/toolbar/BottomToolbarPhone.java

Issue 2844373003: [Home] Reduce bottom control container height (Closed)
Patch Set: Fix app menu positioning Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/toolbar/BottomToolbarPhone.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/toolbar/BottomToolbarPhone.java b/chrome/android/java/src/org/chromium/chrome/browser/toolbar/BottomToolbarPhone.java
index 314eebe2bd766bfa110b50a5931c18c92c441b49..22ec494c32250e42a49e3a3ed89fdb66840b6a51 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/toolbar/BottomToolbarPhone.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/toolbar/BottomToolbarPhone.java
@@ -117,6 +117,8 @@ public class BottomToolbarPhone extends ToolbarPhone {
context.getResources(), R.drawable.toolbar_handle_dark);
mHandleLight = ApiCompatibilityUtils.getDrawable(
context.getResources(), R.drawable.toolbar_handle_light);
+ mLocationBarVerticalMargin =
+ getResources().getDimensionPixelOffset(R.dimen.bottom_location_bar_vertical_margin);
}
@Override
@@ -193,6 +195,11 @@ public class BottomToolbarPhone extends ToolbarPhone {
public void onFinishInflate() {
super.onFinishInflate();
+ // Add extra top margin to the URL bar to compensate for the change to location bar's
+ // vertical margin in the constructor.
+ ((MarginLayoutParams) mLocationBar.findViewById(R.id.url_bar).getLayoutParams()).topMargin =
+ getResources().getDimensionPixelSize(R.dimen.bottom_toolbar_url_bar_top_margin);
+
// Exclude the location bar from the list of browsing mode views. This prevents its
// visibility from changing during transitions.
mBrowsingModeViews.remove(mLocationBar);

Powered by Google App Engine
This is Rietveld 408576698