Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(563)

Issue 2844163002: Remove public methods on StyleBoxData and rename member. (Closed)

Created:
3 years, 8 months ago by shend
Modified:
3 years, 7 months ago
Reviewers:
meade_UTC10
CC:
blink-reviews, blink-reviews-style_chromium.org, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove public methods on StyleBoxData and rename member. This patch does two things: - Remove public methods on StyleBoxData. This is because these methods will no longer exist once we generate StyleBoxData. - Rename vertical_align_ -> vertical_align_length_, to differentiate it from the keyword part of vertical-align (also called vertical_align_, stored in ComputedStyleBase) This is preparation for generating StyleBoxData. BUG=628043 Review-Url: https://codereview.chromium.org/2844163002 Cr-Commit-Position: refs/heads/master@{#467606} Committed: https://chromium.googlesource.com/chromium/src/+/2b61f1cbbd44c6ada5f7022ff3a55493f54836f5

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -50 lines) Patch
M third_party/WebKit/Source/core/style/ComputedStyle.h View 5 chunks +15 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.cpp View 3 chunks +16 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/core/style/StyleBoxData.h View 2 chunks +1 line, -20 lines 0 comments Download
M third_party/WebKit/Source/core/style/StyleBoxData.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 16 (12 generated)
shend
Hi Eddy, PTAL
3 years, 8 months ago (2017-04-27 01:20:22 UTC) #3
meade_UTC10
lgtm
3 years, 7 months ago (2017-04-27 03:43:13 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2844163002/20001
3 years, 7 months ago (2017-04-27 06:27:15 UTC) #13
commit-bot: I haz the power
3 years, 7 months ago (2017-04-27 06:31:23 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/2b61f1cbbd44c6ada5f7022ff3a5...

Powered by Google App Engine
This is Rietveld 408576698