Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Issue 2841353002: Split initial methods of (/max/min)(width/height) on ComputedStyle. (Closed)

Created:
3 years, 8 months ago by shend
Modified:
3 years, 8 months ago
Reviewers:
meade_UTC10
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Split initial methods of (/max/min)(width/height) on ComputedStyle. Currently: - width and height share the same initial method InitialSize - minWidth and minHeight share the same initial method InitialMinSize - maxWidth and maxHeight share the same initial method InitialMaxSize This patch makes each of those properties use its own initial method so that they can be more easily generated (the generator does not support sharing of initial methods). Diff of generated files: https://gist.github.com/d058699c786d95762067b28ccfbc1774/revisions BUG=628043 Review-Url: https://codereview.chromium.org/2841353002 Cr-Commit-Position: refs/heads/master@{#467603} Committed: https://chromium.googlesource.com/chromium/src/+/e965dad365db87339dfcfdf7d2d98c7eff17712c

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : gco rename-style-box && gut #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -15 lines) Patch
M third_party/WebKit/Source/core/css/CSSProperties.json5 View 5 chunks +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBox.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.h View 1 chunk +6 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/style/StyleBoxData.cpp View 1 1 chunk +4 lines, -4 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 18 (14 generated)
shend
Hi Eddy, PTAL :)
3 years, 8 months ago (2017-04-27 00:57:38 UTC) #3
meade_UTC10
lgtm
3 years, 8 months ago (2017-04-27 06:16:21 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2841353002/40001
3 years, 8 months ago (2017-04-27 06:21:27 UTC) #15
commit-bot: I haz the power
3 years, 8 months ago (2017-04-27 06:25:55 UTC) #18
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/e965dad365db87339dfcfdf7d2d9...

Powered by Google App Engine
This is Rietveld 408576698