Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(3)

Issue 2843063002: Remove post_launch_on_client_thread_called (Closed)

Created:
6 months, 3 weeks ago by boliu
Modified:
6 months, 3 weeks ago
Reviewers:
Jay Civelli
CC:
chromium-reviews, jam, darin-cc_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove post_launch_on_client_thread_called This is a follow up to refs/heads/master@{#465155}. Android now always calls OnChildProcessStarted on the launcher thread, which means the complexity to deal with the call directly happening on the client thread can be removed. BUG=689758 Review-Url: https://codereview.chromium.org/2843063002 Cr-Original-Commit-Position: refs/heads/master@{#467463} Committed: https://chromium.googlesource.com/chromium/src/+/213830d7d68eefddedc6199bf699dfac3d5481e8 Review-Url: https://codereview.chromium.org/2843063002 Cr-Commit-Position: refs/heads/master@{#467514} Committed: https://chromium.googlesource.com/chromium/src/+/5674fee66841f27be43267127bd8586b89042b82

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove post_launch_on_client_thread_called #

Messages

Total messages: 24 (13 generated)
boliu
ptal
6 months, 3 weeks ago (2017-04-26 18:17:43 UTC) #5
Jay Civelli
lgtm https://codereview.chromium.org/2843063002/diff/1/content/browser/child_process_launcher_helper.h File content/browser/child_process_launcher_helper.h (right): https://codereview.chromium.org/2843063002/diff/1/content/browser/child_process_launcher_helper.h#newcode125 content/browser/child_process_launcher_helper.h:125: // If |post_launch_on_client_thread_called| is false, Remove this part ...
6 months, 3 weeks ago (2017-04-26 18:29:29 UTC) #6
Jay Civelli
lgtm
6 months, 3 weeks ago (2017-04-26 18:29:31 UTC) #7
boliu
https://codereview.chromium.org/2843063002/diff/1/content/browser/child_process_launcher_helper.h File content/browser/child_process_launcher_helper.h (right): https://codereview.chromium.org/2843063002/diff/1/content/browser/child_process_launcher_helper.h#newcode125 content/browser/child_process_launcher_helper.h:125: // If |post_launch_on_client_thread_called| is false, On 2017/04/26 18:29:29, Jay ...
6 months, 3 weeks ago (2017-04-26 18:32:21 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2843063002/20001
6 months, 3 weeks ago (2017-04-26 18:33:26 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/213830d7d68eefddedc6199bf699dfac3d5481e8
6 months, 3 weeks ago (2017-04-26 21:26:35 UTC) #15
sashab
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2839353002/ by sashab@chromium.org. ...
6 months, 3 weeks ago (2017-04-26 23:17:00 UTC) #16
boliu
On 2017/04/26 23:17:00, sashab wrote: > A revert of this CL (patchset #2 id:20001) has ...
6 months, 3 weeks ago (2017-04-26 23:21:51 UTC) #17
boliu
On 2017/04/26 23:21:51, boliu wrote: > On 2017/04/26 23:17:00, sashab wrote: > > A revert ...
6 months, 3 weeks ago (2017-04-26 23:26:34 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2843063002/20001
6 months, 3 weeks ago (2017-04-26 23:34:29 UTC) #21
commit-bot: I haz the power
6 months, 3 weeks ago (2017-04-26 23:42:18 UTC) #24
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/5674fee66841f27be43267127bd8...

Powered by Google App Engine
This is Rietveld efc10ee0f