Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 2839353002: Revert of Remove post_launch_on_client_thread_called (Closed)

Created:
3 years, 8 months ago by sashab
Modified:
3 years, 8 months ago
Reviewers:
Jay Civelli, boliu
CC:
chromium-reviews, jam, darin-cc_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove post_launch_on_client_thread_called (patchset #2 id:20001 of https://codereview.chromium.org/2843063002/ ) Reason for revert: Caused failure on WebKit Win10 builder: webkit_python_tests webkit_python_tests webkitpy/layout_tests/run_webkit_tests_unittest/RunTest/test_child_processes_2 https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Win10/builds/21699 Original issue's description: > Remove post_launch_on_client_thread_called > > This is a follow up to refs/heads/master@{#465155}. Android now always > calls OnChildProcessStarted on the launcher thread, which means the > complexity to deal with the call directly happening on the client thread > can be removed. > > BUG=689758 > > Review-Url: https://codereview.chromium.org/2843063002 > Cr-Commit-Position: refs/heads/master@{#467463} > Committed: https://chromium.googlesource.com/chromium/src/+/213830d7d68eefddedc6199bf699dfac3d5481e8 TBR=jcivelli@chromium.org,boliu@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=689758 Review-Url: https://codereview.chromium.org/2839353002 Cr-Commit-Position: refs/heads/master@{#467502} Committed: https://chromium.googlesource.com/chromium/src/+/2582adf8aedbc7c9538aec544f80bf6379b11cc5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -14 lines) Patch
M content/browser/child_process_launcher_helper.h View 1 chunk +7 lines, -3 lines 0 comments Download
M content/browser/child_process_launcher_helper.cc View 1 chunk +11 lines, -8 lines 0 comments Download
M content/browser/child_process_launcher_helper_android.cc View 2 chunks +22 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
sashab
Created Revert of Remove post_launch_on_client_thread_called
3 years, 8 months ago (2017-04-26 23:17:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2839353002/1
3 years, 8 months ago (2017-04-26 23:18:09 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/2582adf8aedbc7c9538aec544f80bf6379b11cc5
3 years, 8 months ago (2017-04-26 23:18:46 UTC) #6
boliu
On 2017/04/26 23:18:46, commit-bot: I haz the power wrote: > Committed patchset #1 (id:1) as ...
3 years, 8 months ago (2017-04-26 23:22:30 UTC) #7
boliu
3 years, 8 months ago (2017-04-26 23:25:27 UTC) #8
Message was sent while issue was closed.
On 2017/04/26 23:22:30, boliu wrote:
> On 2017/04/26 23:18:46, commit-bot: I haz the power wrote:
> > Committed patchset #1 (id:1) as
> >
>
https://chromium.googlesource.com/chromium/src/+/2582adf8aedbc7c9538aec544f80...
> 
> Uhh... this change only had material effect on android

Next build already has green webkit_python_tests without this revert:
https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Win1...

relanding

Powered by Google App Engine
This is Rietveld 408576698