|
|
Created:
3 years, 8 months ago by boliu Modified:
3 years, 8 months ago Reviewers:
Jay Civelli CC:
chromium-reviews, jam, darin-cc_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionRemove post_launch_on_client_thread_called
This is a follow up to refs/heads/master@{#465155}. Android now always
calls OnChildProcessStarted on the launcher thread, which means the
complexity to deal with the call directly happening on the client thread
can be removed.
BUG=689758
Review-Url: https://codereview.chromium.org/2843063002
Cr-Original-Commit-Position: refs/heads/master@{#467463}
Committed: https://chromium.googlesource.com/chromium/src/+/213830d7d68eefddedc6199bf699dfac3d5481e8
Review-Url: https://codereview.chromium.org/2843063002
Cr-Commit-Position: refs/heads/master@{#467514}
Committed: https://chromium.googlesource.com/chromium/src/+/5674fee66841f27be43267127bd8586b89042b82
Patch Set 1 #
Total comments: 2
Patch Set 2 : Remove post_launch_on_client_thread_called #
Messages
Total messages: 24 (13 generated)
The CQ bit was checked by boliu@chromium.org to run a CQ dry run
Description was changed from ========== Remove post_launch_on_client_thread_called This is a follow up to refs/heads/master@{#465155}. Android now always calls OnChildProcessStarted on the launcher thread, which means the complexity to deal with the call directly happening on the client thread can be reoved. BUG=689758 ========== to ========== Remove post_launch_on_client_thread_called This is a follow up to refs/heads/master@{#465155}. Android now always calls OnChildProcessStarted on the launcher thread, which means the complexity to deal with the call directly happening on the client thread can be removed. BUG=689758 ==========
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
boliu@chromium.org changed reviewers: + jcivelli@chromium.org
ptal
lgtm https://codereview.chromium.org/2843063002/diff/1/content/browser/child_proce... File content/browser/child_process_launcher_helper.h (right): https://codereview.chromium.org/2843063002/diff/1/content/browser/child_proce... content/browser/child_process_launcher_helper.h:125: // If |post_launch_on_client_thread_called| is false, Remove this part of the comment.
lgtm
The CQ bit was unchecked by boliu@chromium.org
https://codereview.chromium.org/2843063002/diff/1/content/browser/child_proce... File content/browser/child_process_launcher_helper.h (right): https://codereview.chromium.org/2843063002/diff/1/content/browser/child_proce... content/browser/child_process_launcher_helper.h:125: // If |post_launch_on_client_thread_called| is false, On 2017/04/26 18:29:29, Jay Civelli wrote: > Remove this part of the comment. Oops, done
The CQ bit was checked by boliu@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from jcivelli@chromium.org Link to the patchset: https://codereview.chromium.org/2843063002/#ps20001 (title: "Remove post_launch_on_client_thread_called")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493231548921530, "parent_rev": "78730f18fc734d034e44d0dc63091562be82edae", "commit_rev": "213830d7d68eefddedc6199bf699dfac3d5481e8"}
Message was sent while issue was closed.
Description was changed from ========== Remove post_launch_on_client_thread_called This is a follow up to refs/heads/master@{#465155}. Android now always calls OnChildProcessStarted on the launcher thread, which means the complexity to deal with the call directly happening on the client thread can be removed. BUG=689758 ========== to ========== Remove post_launch_on_client_thread_called This is a follow up to refs/heads/master@{#465155}. Android now always calls OnChildProcessStarted on the launcher thread, which means the complexity to deal with the call directly happening on the client thread can be removed. BUG=689758 Review-Url: https://codereview.chromium.org/2843063002 Cr-Commit-Position: refs/heads/master@{#467463} Committed: https://chromium.googlesource.com/chromium/src/+/213830d7d68eefddedc6199bf699... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/213830d7d68eefddedc6199bf699...
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2839353002/ by sashab@chromium.org. The reason for reverting is: Caused failure on WebKit Win10 builder: webkit_python_tests webkit_python_tests webkitpy/layout_tests/run_webkit_tests_unittest/RunTest/test_child_processes_2 https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Win1... .
Message was sent while issue was closed.
On 2017/04/26 23:17:00, sashab wrote: > A revert of this CL (patchset #2 id:20001) has been created in > https://codereview.chromium.org/2839353002/ by mailto:sashab@chromium.org. > > The reason for reverting is: Caused failure on WebKit Win10 builder: > webkit_python_tests webkit_python_tests > webkitpy/layout_tests/run_webkit_tests_unittest/RunTest/test_child_processes_2 > https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Win1... > . Uhh... this change only had material effect on android
Message was sent while issue was closed.
Description was changed from ========== Remove post_launch_on_client_thread_called This is a follow up to refs/heads/master@{#465155}. Android now always calls OnChildProcessStarted on the launcher thread, which means the complexity to deal with the call directly happening on the client thread can be removed. BUG=689758 Review-Url: https://codereview.chromium.org/2843063002 Cr-Commit-Position: refs/heads/master@{#467463} Committed: https://chromium.googlesource.com/chromium/src/+/213830d7d68eefddedc6199bf699... ========== to ========== Remove post_launch_on_client_thread_called This is a follow up to refs/heads/master@{#465155}. Android now always calls OnChildProcessStarted on the launcher thread, which means the complexity to deal with the call directly happening on the client thread can be removed. BUG=689758 Review-Url: https://codereview.chromium.org/2843063002 Cr-Commit-Position: refs/heads/master@{#467463} Committed: https://chromium.googlesource.com/chromium/src/+/213830d7d68eefddedc6199bf699... ==========
On 2017/04/26 23:21:51, boliu wrote: > On 2017/04/26 23:17:00, sashab wrote: > > A revert of this CL (patchset #2 id:20001) has been created in > > https://codereview.chromium.org/2839353002/ by mailto:sashab@chromium.org. > > > > The reason for reverting is: Caused failure on WebKit Win10 builder: > > webkit_python_tests webkit_python_tests > > webkitpy/layout_tests/run_webkit_tests_unittest/RunTest/test_child_processes_2 > > > https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Win1... > > . > > Uhh... this change only had material effect on android Next build already has green webkit_python_tests without this revert: https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Win1... relanding without any changes
The CQ bit was checked by boliu@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493249617145670, "parent_rev": "66aacfa671360982f234c0fbd3b186efe21ee763", "commit_rev": "5674fee66841f27be43267127bd8586b89042b82"}
Message was sent while issue was closed.
Description was changed from ========== Remove post_launch_on_client_thread_called This is a follow up to refs/heads/master@{#465155}. Android now always calls OnChildProcessStarted on the launcher thread, which means the complexity to deal with the call directly happening on the client thread can be removed. BUG=689758 Review-Url: https://codereview.chromium.org/2843063002 Cr-Commit-Position: refs/heads/master@{#467463} Committed: https://chromium.googlesource.com/chromium/src/+/213830d7d68eefddedc6199bf699... ========== to ========== Remove post_launch_on_client_thread_called This is a follow up to refs/heads/master@{#465155}. Android now always calls OnChildProcessStarted on the launcher thread, which means the complexity to deal with the call directly happening on the client thread can be removed. BUG=689758 Review-Url: https://codereview.chromium.org/2843063002 Cr-Original-Commit-Position: refs/heads/master@{#467463} Committed: https://chromium.googlesource.com/chromium/src/+/213830d7d68eefddedc6199bf699... Review-Url: https://codereview.chromium.org/2843063002 Cr-Commit-Position: refs/heads/master@{#467514} Committed: https://chromium.googlesource.com/chromium/src/+/5674fee66841f27be43267127bd8... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/5674fee66841f27be43267127bd8... |