Add back Rect parcelable to onSmartClipDataExtracted.

Add back Rect parcelable to onSmartClipDataExtracted.

In http://crrev.com/448816 I removed this on the observation it was
unused on the device I tried and provided no useful information.  Crash
reports are now showing the Galaxy Note 3 does use it, so add it back.
Unlike in the previous implementation, it's just stashed at time of
request instead of doing a round-trip to Blink and back.

BUG=714877
Review-Url: https://codereview.chromium.org/2842653004
Cr-Commit-Position: refs/heads/master@{#467543}
Committed: https://chromium.googlesource.com/chromium/src/+/ccf1656dee55dfa118c3c5c8cede9b72c5c78d91

[aelias_OOO_until_Jul13, 2017-04-25 19:46:30]

The CQ bit was checked by aelias@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-25 19:47:12]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[aelias_OOO_until_Jul13, 2017-04-25 20:02:24]

The CQ bit was checked by aelias@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-25 20:02:53]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[aelias_OOO_until_Jul13, 2017-04-25 20:04:00]

aelias@chromium.org changed reviewers:
+ dtrainor@chromium.org

[aelias_OOO_until_Jul13, 2017-04-25 20:04:45]

Hi dtrainor@, PTAL.

[commit-bot: I haz the power, 2017-04-25 22:40:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-25 22:40:37]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[aelias_OOO_until_Jul13, 2017-04-26 02:04:12]

The CQ bit was checked by aelias@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-26 02:04:45]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-26 03:15:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-26 03:15:45]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[David Trainor- moved to gerrit, 2017-04-26 20:58:17]

https://codereview.chromium.org/2842653004/diff/40001/android_webview/java/sr...
File android_webview/java/src/org/chromium/android_webview/AwContents.java
(right):

https://codereview.chromium.org/2842653004/diff/40001/android_webview/java/sr...
android_webview/java/src/org/chromium/android_webview/AwContents.java:3017:
mWebContents.requestSmartClipExtract(new Rect(x, y, x + width, y + height),
It looks like rect isn't scaled by dpi but the other values are.  Is this on
purpose/expected?  If it is, can we put something in the API explaining this (or
just make it all non-dpi scaled and do the scaling inside WebContents)?

https://codereview.chromium.org/2842653004/diff/40001/content/public/android/...
File
content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java
(right):

https://codereview.chromium.org/2842653004/diff/40001/content/public/android/...
content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java:430:
mSmartClipCallback.storeRequestRect(originalRect);
Should we just build the rect here and do the dpi scaling inside this function
when we call nativeRequestSmartClipExtract?

[aelias_OOO_until_Jul13, 2017-04-26 23:17:21]

The CQ bit was checked by aelias@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-26 23:18:10]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[aelias_OOO_until_Jul13, 2017-04-26 23:18:15]

https://codereview.chromium.org/2842653004/diff/40001/content/public/android/...
File
content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java
(right):

https://codereview.chromium.org/2842653004/diff/40001/content/public/android/...
content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java:430:
mSmartClipCallback.storeRequestRect(originalRect);
On 2017/04/26 at 20:58:17, David Trainor-ping if over 24h wrote:
> Should we just build the rect here and do the dpi scaling inside this function
when we call nativeRequestSmartClipExtract?

OK, done.  I needed to pass in the RenderCoordinates object as an additional
parameter to have the DPI information here.

[David Trainor- moved to gerrit, 2017-04-26 23:47:58]

lgtm

[aelias_OOO_until_Jul13, 2017-04-26 23:54:56]

aelias@chromium.org changed reviewers:
+ sgurun@chromium.org

[aelias_OOO_until_Jul13, 2017-04-26 23:55:03]

+sgurun for android_webview/

[commit-bot: I haz the power, 2017-04-27 01:05:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-27 01:05:09]

Dry run: This issue passed the CQ dry run.

[sgurun-gerrit only, 2017-04-27 01:31:55]

lgtm

[aelias_OOO_until_Jul13, 2017-04-27 01:41:27]

The CQ bit was checked by aelias@chromium.org

[commit-bot: I haz the power, 2017-04-27 01:42:21]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-27 01:48:50]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1493257287206970,
"parent_rev": "95862a52c7bc1a5846259619243289805d095b70", "commit_rev":
"ccf1656dee55dfa118c3c5c8cede9b72c5c78d91"}

[commit-bot: I haz the power, 2017-04-27 01:48:59]

Description was changed from

==========
Add back Rect parcelable to onSmartClipDataExtracted.

In http://crrev.com/448816 I removed this on the observation it was
unused on the device I tried and provided no useful information.  Crash
reports are now showing the Galaxy Note 3 does use it, so add it back.
Unlike in the previous implementation, it's just stashed at time of
request instead of doing a round-trip to Blink and back.

BUG=714877
==========

to

==========
Add back Rect parcelable to onSmartClipDataExtracted.

In http://crrev.com/448816 I removed this on the observation it was
unused on the device I tried and provided no useful information.  Crash
reports are now showing the Galaxy Note 3 does use it, so add it back.
Unlike in the previous implementation, it's just stashed at time of
request instead of doing a round-trip to Blink and back.

BUG=714877

Review-Url: https://codereview.chromium.org/2842653004
Cr-Commit-Position: refs/heads/master@{#467543}
Committed:
https://chromium.googlesource.com/chromium/src/+/ccf1656dee55dfa118c3c5c8cede...
==========

[commit-bot: I haz the power, 2017-04-27 01:49:00]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/ccf1656dee55dfa118c3c5c8cede...