Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Side by Side Diff: content/public/android/java/src/org/chromium/content_public/browser/WebContents.java

Issue 2842653004: Add back Rect parcelable to onSmartClipDataExtracted. (Closed)
Patch Set: Code review comments Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 package org.chromium.content_public.browser; 5 package org.chromium.content_public.browser;
6 6
7 import android.os.Handler; 7 import android.os.Handler;
8 import android.os.Parcelable; 8 import android.os.Parcelable;
9 9
10 import org.chromium.base.VisibleForTesting; 10 import org.chromium.base.VisibleForTesting;
11 import org.chromium.content.browser.RenderCoordinates;
11 import org.chromium.ui.OverscrollRefreshHandler; 12 import org.chromium.ui.OverscrollRefreshHandler;
12 import org.chromium.ui.base.EventForwarder; 13 import org.chromium.ui.base.EventForwarder;
13 import org.chromium.ui.base.WindowAndroid; 14 import org.chromium.ui.base.WindowAndroid;
14 15
15 /** 16 /**
16 * The WebContents Java wrapper to allow communicating with the native WebConten ts object. 17 * The WebContents Java wrapper to allow communicating with the native WebConten ts object.
17 * 18 *
18 * Note about serialization and {@link Parcelable}: 19 * Note about serialization and {@link Parcelable}:
19 * This object is serializable and deserializable as long as it is done in the same process. That 20 * This object is serializable and deserializable as long as it is done in the same process. That
20 * means it can be passed between Activities inside this process, but not preser ved beyond the 21 * means it can be passed between Activities inside this process, but not preser ved beyond the
(...skipping 296 matching lines...) Expand 10 before | Expand all | Expand 10 after
317 * {@link android.graphics.Color#TRANSPARENT} means there was no theme color specified. 318 * {@link android.graphics.Color#TRANSPARENT} means there was no theme color specified.
318 * 319 *
319 * @return The theme color for the content as set by the theme-color meta ta g. 320 * @return The theme color for the content as set by the theme-color meta ta g.
320 */ 321 */
321 int getThemeColor(); 322 int getThemeColor();
322 323
323 /** 324 /**
324 * Initiate extraction of text, HTML, and other information for clipping pup oses (smart clip) 325 * Initiate extraction of text, HTML, and other information for clipping pup oses (smart clip)
325 * from the rectangle area defined by starting positions (x and y), and widt h and height. 326 * from the rectangle area defined by starting positions (x and y), and widt h and height.
326 */ 327 */
327 void requestSmartClipExtract(int x, int y, int width, int height); 328 void requestSmartClipExtract(
329 int x, int y, int width, int height, RenderCoordinates coordinateSpa ce);
328 330
329 /** 331 /**
330 * Register a handler to handle smart clip data once extraction is done. 332 * Register a handler to handle smart clip data once extraction is done.
331 */ 333 */
332 void setSmartClipResultHandler(final Handler smartClipHandler); 334 void setSmartClipResultHandler(final Handler smartClipHandler);
333 335
334 /** 336 /**
335 * Requests a snapshop of accessibility tree. The result is provided asynchr onously 337 * Requests a snapshop of accessibility tree. The result is provided asynchr onously
336 * using the callback 338 * using the callback
337 * @param callback The callback to be called when the snapshot is ready. The callback 339 * @param callback The callback to be called when the snapshot is ready. The callback
(...skipping 78 matching lines...) Expand 10 before | Expand all | Expand 10 after
416 public void simulateRendererKilledForTesting(boolean wasOomProtected); 418 public void simulateRendererKilledForTesting(boolean wasOomProtected);
417 419
418 /** 420 /**
419 * Notifies the WebContents about the new persistent video status. It should be called whenever 421 * Notifies the WebContents about the new persistent video status. It should be called whenever
420 * the value changes. 422 * the value changes.
421 * 423 *
422 * @param value Whether there is a persistent video associated with this Web Contents. 424 * @param value Whether there is a persistent video associated with this Web Contents.
423 */ 425 */
424 public void setHasPersistentVideo(boolean value); 426 public void setHasPersistentVideo(boolean value);
425 } 427 }
OLDNEW
« no previous file with comments | « content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698