content/public/android/java/src/org/chromium/content/browser/ContentView.java - Issue 2842653004: Add back Rect parcelable to onSmartClipDataExtracted.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/ContentView.java

Issue 2842653004: Add back Rect parcelable to onSmartClipDataExtracted. (Closed)

Patch Set: Code review comments Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/SmartClipProviderTest.java ('k') | content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/java/src/org/chromium/content/browser/ContentView.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/ContentView.java b/content/public/android/java/src/org/chromium/content/browser/ContentView.java

index 0aecf3ee9e0e4a3af08fe4a385a1f1fea275fa7c..7e233b7771002bdbcda6a754cc6083e2207cff37 100644

--- a/content/public/android/java/src/org/chromium/content/browser/ContentView.java

+++ b/content/public/android/java/src/org/chromium/content/browser/ContentView.java

@@ -298,10 +298,8 @@ public class ContentView extends FrameLayout

// Implements SmartClipProvider

@Override

public void extractSmartClipData(int x, int y, int width, int height) {

- float dpi = mContentViewCore.getRenderCoordinates().getDeviceScaleFactor();

- y -= mContentViewCore.getRenderCoordinates().getContentOffsetYPix();

mContentViewCore.getWebContents().requestSmartClipExtract(

- (int) (x / dpi), (int) (y / dpi), (int) (width / dpi), (int) (height / dpi));

+ x, y, width, height, mContentViewCore.getRenderCoordinates());

}

// Implements SmartClipProvider