Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(615)

Issue 2842643003: Disable flaky WebRtcInternalsPerfBrowserTest on Windows. (Closed)

Created:
3 years, 8 months ago by Max Morin
Modified:
3 years, 8 months ago
Reviewers:
CC:
chromium-reviews, chfremer+watch_chromium.org, phoglund+watch_chromium.org, feature-media-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable flaky WebRtcInternalsPerfBrowserTest on Windows. WebRtcInternalsPerfBrowserTest.MANUAL_RunsAudioVideoCall60SecsAndLogsInternalMetricsH264 is flaky on Windows. BUG=703579 TBR=hbos@chromium.org Review-Url: https://codereview.chromium.org/2842643003 Cr-Commit-Position: refs/heads/master@{#466964} Committed: https://chromium.googlesource.com/chromium/src/+/774479d06817e48e69fdce1d464cc2299c81e01d

Patch Set 1 #

Patch Set 2 : Spell #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M chrome/browser/media/webrtc/webrtc_internals_perf_browsertest.cc View 1 1 chunk +9 lines, -1 line 0 comments Download

Messages

Total messages: 7 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2842643003/20001
3 years, 8 months ago (2017-04-25 12:45:49 UTC) #3
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/774479d06817e48e69fdce1d464cc2299c81e01d
3 years, 8 months ago (2017-04-25 13:25:22 UTC) #6
emircan
3 years, 7 months ago (2017-05-23 20:07:49 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2899103002/ by emircan@chromium.org.

The reason for reverting is: This test should pass after the fixes on issue
webrtc:7532. See the explanation
https://bugs.chromium.org/p/chromium/issues/detail?id=722746#c21 for how they
are related..

Powered by Google App Engine
This is Rietveld 408576698