Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Side by Side Diff: chrome/browser/media/webrtc/webrtc_internals_perf_browsertest.cc

Issue 2842643003: Disable flaky WebRtcInternalsPerfBrowserTest on Windows. (Closed)
Patch Set: Spell Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <memory> 5 #include <memory>
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "base/files/file_util.h" 8 #include "base/files/file_util.h"
9 #include "base/json/json_reader.h" 9 #include "base/json/json_reader.h"
10 #include "base/macros.h" 10 #include "base/macros.h"
(...skipping 219 matching lines...) Expand 10 before | Expand all | Expand 10 after
230 } 230 }
231 231
232 IN_PROC_BROWSER_TEST_F( 232 IN_PROC_BROWSER_TEST_F(
233 WebRtcInternalsPerfBrowserTest, 233 WebRtcInternalsPerfBrowserTest,
234 MANUAL_RunsAudioVideoCall60SecsAndLogsInternalMetricsVp9) { 234 MANUAL_RunsAudioVideoCall60SecsAndLogsInternalMetricsVp9) {
235 RunsAudioVideoCall60SecsAndLogsInternalMetrics("VP9"); 235 RunsAudioVideoCall60SecsAndLogsInternalMetrics("VP9");
236 } 236 }
237 237
238 #if BUILDFLAG(RTC_USE_H264) 238 #if BUILDFLAG(RTC_USE_H264)
239 239
240 // Flaky on Windows, crbug.com/703579.
241 #if defined(OS_WIN)
242 #define MAYBE_MANUAL_RunsAudioVideoCall60SecsAndLogsInternalMetricsH264 \
243 DISABLED_MANUAL_RunsAudioVideoCall60SecsAndLogsInternalMetricsH264
244 #else
245 #define MAYBE_MANUAL_RunsAudioVideoCall60SecsAndLogsInternalMetricsH264 \
246 MANUAL_RunsAudioVideoCall60SecsAndLogsInternalMetricsH264
247 #endif
240 IN_PROC_BROWSER_TEST_F( 248 IN_PROC_BROWSER_TEST_F(
241 WebRtcInternalsPerfBrowserTest, 249 WebRtcInternalsPerfBrowserTest,
242 MANUAL_RunsAudioVideoCall60SecsAndLogsInternalMetricsH264) { 250 MAYBE_MANUAL_RunsAudioVideoCall60SecsAndLogsInternalMetricsH264) {
243 // Only run test if run-time feature corresponding to |rtc_use_h264| is on. 251 // Only run test if run-time feature corresponding to |rtc_use_h264| is on.
244 if (!base::FeatureList::IsEnabled(content::kWebRtcH264WithOpenH264FFmpeg)) { 252 if (!base::FeatureList::IsEnabled(content::kWebRtcH264WithOpenH264FFmpeg)) {
245 LOG(WARNING) << "Run-time feature WebRTC-H264WithOpenH264FFmpeg disabled. " 253 LOG(WARNING) << "Run-time feature WebRTC-H264WithOpenH264FFmpeg disabled. "
246 "Skipping WebRtcInternalsPerfBrowserTest." 254 "Skipping WebRtcInternalsPerfBrowserTest."
247 "MANUAL_RunsAudioVideoCall60SecsAndLogsInternalMetricsH264 (test " 255 "MANUAL_RunsAudioVideoCall60SecsAndLogsInternalMetricsH264 (test "
248 "\"OK\")"; 256 "\"OK\")";
249 return; 257 return;
250 } 258 }
251 RunsAudioVideoCall60SecsAndLogsInternalMetrics("H264"); 259 RunsAudioVideoCall60SecsAndLogsInternalMetrics("H264");
252 } 260 }
253 261
254 #endif // BUILDFLAG(RTC_USE_H264) 262 #endif // BUILDFLAG(RTC_USE_H264)
255 263
256 IN_PROC_BROWSER_TEST_F( 264 IN_PROC_BROWSER_TEST_F(
257 WebRtcInternalsPerfBrowserTest, 265 WebRtcInternalsPerfBrowserTest,
258 MANUAL_RunsOneWayCall60SecsAndLogsInternalMetricsDefault) { 266 MANUAL_RunsOneWayCall60SecsAndLogsInternalMetricsDefault) {
259 RunsOneWayCall60SecsAndLogsInternalMetrics("", false); 267 RunsOneWayCall60SecsAndLogsInternalMetrics("", false);
260 } 268 }
261 269
262 IN_PROC_BROWSER_TEST_F( 270 IN_PROC_BROWSER_TEST_F(
263 WebRtcInternalsPerfBrowserTest, 271 WebRtcInternalsPerfBrowserTest,
264 MANUAL_RunsOneWayCall60SecsAndLogsInternalMetricsWithOpusDtx) { 272 MANUAL_RunsOneWayCall60SecsAndLogsInternalMetricsWithOpusDtx) {
265 RunsOneWayCall60SecsAndLogsInternalMetrics("", true); 273 RunsOneWayCall60SecsAndLogsInternalMetrics("", true);
266 } 274 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698