Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(591)

Unified Diff: chrome/browser/media/webrtc/webrtc_internals_perf_browsertest.cc

Issue 2842643003: Disable flaky WebRtcInternalsPerfBrowserTest on Windows. (Closed)
Patch Set: Spell Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/media/webrtc/webrtc_internals_perf_browsertest.cc
diff --git a/chrome/browser/media/webrtc/webrtc_internals_perf_browsertest.cc b/chrome/browser/media/webrtc/webrtc_internals_perf_browsertest.cc
index 7b5f6ddac60e3034eab58427d409a099e738b0f2..beb8f6b5285e64f09c23cb045bd5797a7f4fab65 100644
--- a/chrome/browser/media/webrtc/webrtc_internals_perf_browsertest.cc
+++ b/chrome/browser/media/webrtc/webrtc_internals_perf_browsertest.cc
@@ -237,9 +237,17 @@ IN_PROC_BROWSER_TEST_F(
#if BUILDFLAG(RTC_USE_H264)
+// Flaky on Windows, crbug.com/703579.
+#if defined(OS_WIN)
+#define MAYBE_MANUAL_RunsAudioVideoCall60SecsAndLogsInternalMetricsH264 \
+ DISABLED_MANUAL_RunsAudioVideoCall60SecsAndLogsInternalMetricsH264
+#else
+#define MAYBE_MANUAL_RunsAudioVideoCall60SecsAndLogsInternalMetricsH264 \
+ MANUAL_RunsAudioVideoCall60SecsAndLogsInternalMetricsH264
+#endif
IN_PROC_BROWSER_TEST_F(
WebRtcInternalsPerfBrowserTest,
- MANUAL_RunsAudioVideoCall60SecsAndLogsInternalMetricsH264) {
+ MAYBE_MANUAL_RunsAudioVideoCall60SecsAndLogsInternalMetricsH264) {
// Only run test if run-time feature corresponding to |rtc_use_h264| is on.
if (!base::FeatureList::IsEnabled(content::kWebRtcH264WithOpenH264FFmpeg)) {
LOG(WARNING) << "Run-time feature WebRTC-H264WithOpenH264FFmpeg disabled. "
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698