(Reland) Expose resources in Robolectric/JUnit tests.

(Reland) Expose resources in Robolectric/JUnit tests.

Will let people use Android resources in Robolectric tests.
To use, specify package_name GN variable in junit_binary
targets with your apps package name.

This change will also (basically) require that you use the
generated wrappers from out_dir/bin/run_<suite name> to run
the tests since GN will be generating many arguments to
pass along to the test runner.

BUG=693573
Review-Url: https://codereview.chromium.org/2819983002
Cr-Commit-Position: refs/heads/master@{#464973}
Committed: https://chromium.googlesource.com/chromium/src/+/30bba37e58b51483b1ec77bc3f697deb8e4033c1

[mikecase (-- gone --), 2017-04-14 23:12:06]

mikecase@chromium.org changed reviewers:
+ jbudorick@chromium.org, nyquist@chromium.org

[mikecase (-- gone --), 2017-04-14 23:12:07]

Had to revert this since one of the bots didn't have all of the resource_zips
listed out in the build_config file. Failure was due to trying to unzip a
non-existent file.

Just added simple check that the zips exists. Patch 1 is the reverted CL.

https://codereview.chromium.org/2819983002/diff/20001/build/android/pylib/loc...
File build/android/pylib/local/machine/local_machine_junit_test_run.py (right):

https://codereview.chromium.org/2819983002/diff/20001/build/android/pylib/loc...
build/android/pylib/local/machine/local_machine_junit_test_run.py:50: if
os.path.exists(resource_zip)])
here is the one line change.

+ if os.path.exists(resource_zip)])

[mikecase (-- gone --), 2017-04-14 23:12:34]

Also, revert CL: https://codereview.chromium.org/2819593002

[mikecase (-- gone --), 2017-04-17 17:46:04]

Description was changed from

==========
(Reland) Expose resources in Robolectric/JUnit tests.

BUG=693573
==========

to

==========
(Reland) Expose resources in Robolectric/JUnit tests.

Will let people use Android resources in Robolectric tests.
To use, specify package_name GN variable in junit_binary
targets with your apps package name.

This change will also (basically) require that you use the
generated wrappers from out_dir/bin/run_<suite name> to run
the tests since GN will be generating many arguments to
pass along to the test runner.

BUG=693573
==========

[mikecase (-- gone --), 2017-04-17 17:47:23]

Added some info to commit desc. Still just a one-line-change reland.

[jbudorick, 2017-04-17 17:48:23]

lgtm

[nyquist, 2017-04-17 17:48:50]

lgtm
But I guess jbudorick should look at the one line change. but that part also
looks good to me, but I don't think that matters :-)

[mikecase (-- gone --), 2017-04-17 18:03:21]

The CQ bit was checked by mikecase@chromium.org

[commit-bot: I haz the power, 2017-04-17 18:03:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-17 19:22:06]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492452201806120,
"parent_rev": "645a85acd14bdef0471070b9f928b0c29c3d3dae", "commit_rev":
"30bba37e58b51483b1ec77bc3f697deb8e4033c1"}

[commit-bot: I haz the power, 2017-04-17 19:22:20]

Description was changed from

==========
(Reland) Expose resources in Robolectric/JUnit tests.

Will let people use Android resources in Robolectric tests.
To use, specify package_name GN variable in junit_binary
targets with your apps package name.

This change will also (basically) require that you use the
generated wrappers from out_dir/bin/run_<suite name> to run
the tests since GN will be generating many arguments to
pass along to the test runner.

BUG=693573
==========

to

==========
(Reland) Expose resources in Robolectric/JUnit tests.

Will let people use Android resources in Robolectric tests.
To use, specify package_name GN variable in junit_binary
targets with your apps package name.

This change will also (basically) require that you use the
generated wrappers from out_dir/bin/run_<suite name> to run
the tests since GN will be generating many arguments to
pass along to the test runner.

BUG=693573

Review-Url: https://codereview.chromium.org/2819983002
Cr-Commit-Position: refs/heads/master@{#464973}
Committed:
https://chromium.googlesource.com/chromium/src/+/30bba37e58b51483b1ec77bc3f69...
==========

[commit-bot: I haz the power, 2017-04-17 19:22:20]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/30bba37e58b51483b1ec77bc3f69...

[alexmos, 2017-04-17 21:29:53]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2824863002/ by alexmos@chromium.org.

The reason for reverting is: Appears to be breaking chrome_junit_tests:
https://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/4...


Stack trace from failed tests:
android.content.res.Resources$NotFoundException: Resource ID #0x7f0a0153
	at android.content.res.ResourcesImpl.getValue(ResourcesImpl.java:190)
	at android.content.res.Resources.getDimensionPixelSize(Resources.java:667)
	at org.chromium.chrome.browser.suggestions.TileGroup.<init>(TileGroup.java:192)
	at
org.chromium.chrome.browser.suggestions.TileGroupTest.testReceiveNewTilesWithoutChanges(TileGroupTest.java:110)
	at
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
	at
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:52)
	at
org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
	at
org.robolectric.RobolectricTestRunner$HelperTestRunner$1.evaluate(RobolectricTestRunner.java:515)
	at
org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
	at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48)
	at org.junit.rules.RunRules.evaluate(RunRules.java:20)
	at
org.robolectric.RobolectricTestRunner$2.evaluate(RobolectricTestRunner.java:316)
	at
org.robolectric.RobolectricTestRunner.runChild(RobolectricTestRunner.java:236)
	at
org.robolectric.RobolectricTestRunner.runChild(RobolectricTestRunner.java:41)
	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
	at
org.robolectric.RobolectricTestRunner$1.evaluate(RobolectricTestRunner.java:176)
	at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
	at
org.chromium.testing.local.GtestComputer$GtestSuiteRunner.run(GtestComputer.java:46)
	at org.junit.runners.Suite.runChild(Suite.java:128)
	at org.junit.runners.Suite.runChild(Suite.java:27)
	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
	at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
	at org.junit.runner.JUnitCore.run(JUnitCore.java:137)
	at org.junit.runner.JUnitCore.run(JUnitCore.java:115)
	at org.chromium.testing.local.JunitTestMain.main(JunitTestMain.java:105)
.

[mikecase (-- gone --), 2017-04-17 21:34:12]

On 2017/04/17 at 21:29:53, alexmos wrote:
> A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2824863002/ by alexmos@chromium.org.
> 
> The reason for reverting is: Appears to be breaking chrome_junit_tests:
https://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/4...

> 
> Stack trace from failed tests:
> android.content.res.Resources$NotFoundException: Resource ID #0x7f0a0153
> 	at android.content.res.ResourcesImpl.getValue(ResourcesImpl.java:190)
> 	at android.content.res.Resources.getDimensionPixelSize(Resources.java:667)
> 	at
org.chromium.chrome.browser.suggestions.TileGroup.<init>(TileGroup.java:192)
> 	at
org.chromium.chrome.browser.suggestions.TileGroupTest.testReceiveNewTilesWithoutChanges(TileGroupTest.java:110)
> 	at
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
> 	at
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> 	at
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:52)
> 	at
org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
> 	at
org.robolectric.RobolectricTestRunner$HelperTestRunner$1.evaluate(RobolectricTestRunner.java:515)
> 	at
org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
> 	at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48)
> 	at org.junit.rules.RunRules.evaluate(RunRules.java:20)
> 	at
org.robolectric.RobolectricTestRunner$2.evaluate(RobolectricTestRunner.java:316)
> 	at
org.robolectric.RobolectricTestRunner.runChild(RobolectricTestRunner.java:236)
> 	at
org.robolectric.RobolectricTestRunner.runChild(RobolectricTestRunner.java:41)
> 	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
> 	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
> 	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
> 	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
> 	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
> 	at
org.robolectric.RobolectricTestRunner$1.evaluate(RobolectricTestRunner.java:176)
> 	at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
> 	at
org.chromium.testing.local.GtestComputer$GtestSuiteRunner.run(GtestComputer.java:46)
> 	at org.junit.runners.Suite.runChild(Suite.java:128)
> 	at org.junit.runners.Suite.runChild(Suite.java:27)
> 	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
> 	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
> 	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
> 	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
> 	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
> 	at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
> 	at org.junit.runner.JUnitCore.run(JUnitCore.java:137)
> 	at org.junit.runner.JUnitCore.run(JUnitCore.java:115)
> 	at org.chromium.testing.local.JunitTestMain.main(JunitTestMain.java:105)
> .

guessing issue is that maybe script that zips the builds for the Android bot
trys to be smart and only zips what it thinks it needs. Maybe I need to add the
resource zips as data_deps or to the .isolate files? Unsure