Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: build/android/lint/suppressions.xml

Issue 2842603002: (Reland x2) Expose resources in Robolectric/JUnit tests. (Closed)
Patch Set: Rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/android/gyp/write_build_config.py ('k') | build/android/pylib/junit/junit_test_instance.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/lint/suppressions.xml
diff --git a/build/android/lint/suppressions.xml b/build/android/lint/suppressions.xml
index 099410c1fe83cdd6421e99692d94bf70ad84fbfb..d76dd3bdcf6b7c637efb89f8dd52c07f235adc4f 100644
--- a/build/android/lint/suppressions.xml
+++ b/build/android/lint/suppressions.xml
@@ -136,11 +136,11 @@ Still reading?
<ignore regexp="tools/android/push_apps_to_background/res"/>
</issue>
<issue id="ImpliedQuantity" severity="Error">
- <ignore regexp="gen/chrome/android/chrome_strings_grd"/>
+ <ignore regexp="chrome/android/chrome_strings_grd"/>
</issue>
<issue id="InconsistentArrays" severity="Error">
- <ignore regexp="gen/android_webview/locale_paks.resources.zip/values/locale-paks.xml"/>
- <ignore regexp="gen/chrome/android/chrome_locale_paks.resources.zip/values/locale-paks.xml"/>
+ <ignore regexp="android_webview/locale_paks.resources.zip/values/locale-paks.xml"/>
+ <ignore regexp="chrome/android/chrome_locale_paks.resources.zip/values/locale-paks.xml"/>
</issue>
<issue id="InconsistentLayout" severity="ignore"/>
<issue id="InefficientWeight" severity="Error">
@@ -232,8 +232,8 @@ Still reading?
<ignore regexp="chrome/android/webapk/libs/client/src/org/chromium/webapk/lib/client/WebApkValidator.java"/>
</issue>
<issue id="PluralsCandidate" severity="Error">
- <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values-en-rGB/android_chrome_strings.xml"/>
- <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values/android_chrome_strings.xml"/>
+ <ignore regexp="chrome/android/chrome_strings_grd.resources.zip/values-en-rGB/android_chrome_strings.xml"/>
+ <ignore regexp="chrome/android/chrome_strings_grd.resources.zip/values/android_chrome_strings.xml"/>
</issue>
<issue id="Recycle" severity="ignore"/>
<issue id="Registered" severity="ignore"/>
@@ -249,17 +249,17 @@ Still reading?
<ignore regexp="chromecast/internal"/>
</issue>
<issue id="StringFormatCount" severity="Error">
- <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values-cs/android_chrome_strings.xml"/>
- <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values-pl/android_chrome_strings.xml"/>
- <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values/android_chrome_strings.xml"/>
+ <ignore regexp="chrome/android/chrome_strings_grd.resources.zip/values-cs/android_chrome_strings.xml"/>
+ <ignore regexp="chrome/android/chrome_strings_grd.resources.zip/values-pl/android_chrome_strings.xml"/>
+ <ignore regexp="chrome/android/chrome_strings_grd.resources.zip/values/android_chrome_strings.xml"/>
</issue>
<issue id="StringFormatInvalid" severity="Error">
- <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values-cs/android_chrome_strings.xml"/>
- <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values-da/android_chrome_strings.xml"/>
- <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values-pl/android_chrome_strings.xml"/>
- <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values-pt-rBR/android_chrome_strings.xml"/>
- <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values-sv/android_chrome_strings.xml"/>
- <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values-tl/android_chrome_strings.xml"/>
+ <ignore regexp="chrome/android/chrome_strings_grd.resources.zip/values-cs/android_chrome_strings.xml"/>
+ <ignore regexp="chrome/android/chrome_strings_grd.resources.zip/values-da/android_chrome_strings.xml"/>
+ <ignore regexp="chrome/android/chrome_strings_grd.resources.zip/values-pl/android_chrome_strings.xml"/>
+ <ignore regexp="chrome/android/chrome_strings_grd.resources.zip/values-pt-rBR/android_chrome_strings.xml"/>
+ <ignore regexp="chrome/android/chrome_strings_grd.resources.zip/values-sv/android_chrome_strings.xml"/>
+ <ignore regexp="chrome/android/chrome_strings_grd.resources.zip/values-tl/android_chrome_strings.xml"/>
</issue>
<issue id="TextFields" severity="Error">
<ignore regexp="chromecast/internal"/>
@@ -272,16 +272,16 @@ Still reading?
<issue id="UnusedAttribute" severity="ignore"/>
<issue id="UnusedIds" severity="ignore"/>
<issue id="UnusedQuantity" severity="Error">
- <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values-cs/android_chrome_strings.xml"/>
- <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values-in/android_chrome_strings.xml"/>
- <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values-ja/android_chrome_strings.xml"/>
- <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values-ko/android_chrome_strings.xml"/>
- <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values-lt/android_chrome_strings.xml"/>
- <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values-sk/android_chrome_strings.xml"/>
- <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values-th/android_chrome_strings.xml"/>
- <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values-vi/android_chrome_strings.xml"/>
- <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values-zh-rCN/android_chrome_strings.xml"/>
- <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values-zh-rTW/android_chrome_strings.xml"/>
+ <ignore regexp="chrome/android/chrome_strings_grd.resources.zip/values-cs/android_chrome_strings.xml"/>
+ <ignore regexp="chrome/android/chrome_strings_grd.resources.zip/values-in/android_chrome_strings.xml"/>
+ <ignore regexp="chrome/android/chrome_strings_grd.resources.zip/values-ja/android_chrome_strings.xml"/>
+ <ignore regexp="chrome/android/chrome_strings_grd.resources.zip/values-ko/android_chrome_strings.xml"/>
+ <ignore regexp="chrome/android/chrome_strings_grd.resources.zip/values-lt/android_chrome_strings.xml"/>
+ <ignore regexp="chrome/android/chrome_strings_grd.resources.zip/values-sk/android_chrome_strings.xml"/>
+ <ignore regexp="chrome/android/chrome_strings_grd.resources.zip/values-th/android_chrome_strings.xml"/>
+ <ignore regexp="chrome/android/chrome_strings_grd.resources.zip/values-vi/android_chrome_strings.xml"/>
+ <ignore regexp="chrome/android/chrome_strings_grd.resources.zip/values-zh-rCN/android_chrome_strings.xml"/>
+ <ignore regexp="chrome/android/chrome_strings_grd.resources.zip/values-zh-rTW/android_chrome_strings.xml"/>
</issue>
<!-- TODO(crbug.com/635567): Fix this properly. -->
<issue id="UnusedResources" severity="ignore"/>
@@ -331,10 +331,10 @@ Still reading?
<ignore regexp="chromecast/internal"/>
<ignore regexp="clank"/>
<ignore regexp="content/shell/android/java/res/mipmap-hdpi/app_icon.png"/>
- <ignore regexp="gen/android_webview/locale_paks.resources.zip/*"/>
- <ignore regexp="gen/android_webview/strings_grd.resources.zip/values/android_webview_strings.xml"/>
- <ignore regexp="gen/components/strings/components_strings_grd.resources.zip/values.*/components_strings.xml"/>
- <ignore regexp="gen/remoting/resources/strings_java.resources.zip/values/remoting_strings.xml"/>
+ <ignore regexp="android_webview/locale_paks.resources.zip/*"/>
+ <ignore regexp="android_webview/strings_grd.resources.zip/values/android_webview_strings.xml"/>
+ <ignore regexp="components/strings/components_strings_grd.resources.zip/values.*/components_strings.xml"/>
+ <ignore regexp="remoting/resources/strings_java.resources.zip/values/remoting_strings.xml"/>
<ignore regexp="remoting/android/java/res/drawable-hdpi/ic_backspace.png"/>
<ignore regexp="remoting/android/java/res/drawable-hdpi/ic_cardboard.png"/>
<ignore regexp="remoting/android/java/res/drawable-hdpi/ic_voice_input.png"/>
« no previous file with comments | « build/android/gyp/write_build_config.py ('k') | build/android/pylib/junit/junit_test_instance.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698