Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 2842113002: Show translate error message when translation failed. (Closed)

Created:
3 years, 8 months ago by Leo
Modified:
3 years, 8 months ago
Reviewers:
gone
CC:
chromium-reviews, agrieve+watch_chromium.org, dfalcantara+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Show translate error message with toast when translation failed. And reset selection to original language. BUG=703887 Review-Url: https://codereview.chromium.org/2842113002 Cr-Commit-Position: refs/heads/master@{#467587} Committed: https://chromium.googlesource.com/chromium/src/+/f39b225b059efaaf2928598209a461982bd13dcb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -34 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java View 2 chunks +10 lines, -5 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/infobar/translate/TranslateTabLayout.java View 2 chunks +0 lines, -29 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
Leo
Show translate error messages if there is and remove unused code. Thanks Dan.
3 years, 8 months ago (2017-04-26 07:26:04 UTC) #3
gone
lgtm
3 years, 8 months ago (2017-04-26 17:05:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2842113002/1
3 years, 8 months ago (2017-04-27 03:30:24 UTC) #6
commit-bot: I haz the power
3 years, 8 months ago (2017-04-27 04:58:30 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f39b225b059efaaf2928598209a4...

Powered by Google App Engine
This is Rietveld 408576698