Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3813)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java

Issue 2842113002: Show translate error message when translation failed. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/infobar/translate/TranslateTabLayout.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java b/chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java
index 272f5777a53f6659f16eaf261d6503264cec03da..30172d7bd48334c15a4a30cd48613a78afe2be0a 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java
@@ -15,6 +15,7 @@ import org.chromium.chrome.R;
import org.chromium.chrome.browser.infobar.translate.TranslateMenu;
import org.chromium.chrome.browser.infobar.translate.TranslateMenuHelper;
import org.chromium.chrome.browser.infobar.translate.TranslateTabLayout;
+import org.chromium.ui.widget.Toast;
/**
* Java version of the compcat translate infobar
@@ -92,11 +93,15 @@ class TranslateCompactInfoBar extends InfoBar
@CalledByNative
private void onPageTranslated(int errorType) {
if (mTabLayout != null) {
- // Success
- if (errorType == 0) {
- mTabLayout.hideProgressBar();
- } else {
- mTabLayout.stopProgressBarAndRevertBack();
+ mTabLayout.hideProgressBar();
+ if (errorType != 0) {
+ Toast.makeText(getContext(), R.string.translate_infobar_error, Toast.LENGTH_SHORT)
+ .show();
+ // Disable OnTabSelectedListener then revert selection.
+ mTabLayout.removeOnTabSelectedListener(this);
+ mTabLayout.getTabAt(SOURCE_TAB_INDEX).select();
+ // Add OnTabSelectedListener back.
+ mTabLayout.addOnTabSelectedListener(this);
}
}
}
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/infobar/translate/TranslateTabLayout.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698