Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1100)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/infobar/translate/TranslateTabLayout.java

Issue 2842113002: Show translate error message when translation failed. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/infobar/translate/TranslateTabLayout.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/infobar/translate/TranslateTabLayout.java b/chrome/android/java/src/org/chromium/chrome/browser/infobar/translate/TranslateTabLayout.java
index 145a0042fe93b7605fceaccb894c8742c0dc5730..78f4c473e2086d5b9c0be1839a2766c0ff936389 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/infobar/translate/TranslateTabLayout.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/infobar/translate/TranslateTabLayout.java
@@ -71,17 +71,6 @@ public class TranslateTabLayout extends TabLayout {
}
/**
- * Select a tab.
- * @param tabPos The position of the tab to select.
- */
- public void selectTab(int tabPos) {
- if (tabPos < 0 || tabPos >= getTabCount() || mTabShowingProgressBar != null) {
- return;
- }
- getTabAt(tabPos).select();
- }
-
- /**
* Show the spinning progress bar on a specified tab.
* @param tabPos The position of the tab to show the progress bar.
*/
@@ -111,24 +100,6 @@ public class TranslateTabLayout extends TabLayout {
mTabShowingProgressBar = null;
}
- /** Stop the spinning progress bar. */
- public void stopProgressBarAndRevertBack() {
- if (mTabShowingProgressBar == null) {
- return;
- }
-
- // TODO(martiw) if we have setContentDescription at showProgressBarOnTab(), we need to
- // revert it here.
-
- if (tabIsSupported(mTabShowingProgressBar)) {
- ((TranslateTabContent) mTabShowingProgressBar.getCustomView()).hideProgressBar();
- }
- // TODO(martiw) See if we need to prevent the following from triggering onTabSelected event.
- selectTab(0); // switch the selection back to the first tab.
-
- mTabShowingProgressBar = null;
- }
-
// Overrided to block children's touch event when showing progress bar.
@Override
public boolean onInterceptTouchEvent(MotionEvent ev) {
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698