Reuse WeakFactory from U2fDevice derived classes

device/u2f/u2f_device.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "u2f_device.h"
 
 #include "base/bind.h"
 #include "u2f_apdu_command.h"
 #include "u2f_apdu_response.h"
 
 namespace device {
 
-U2fDevice::U2fDevice()
-    : channel_id_(kBroadcastChannel), capabilities_(0), weak_factory_(this) {}
+U2fDevice::U2fDevice() : channel_id_(kBroadcastChannel), capabilities_(0) {}
 
 U2fDevice::~U2fDevice() {}
 
 void U2fDevice::Register(const std::vector<uint8_t>& app_param,
                          const std::vector<uint8_t>& challenge_param,
                          const MessageCallback& callback) {
   std::unique_ptr<U2fApduCommand> register_cmd =
       U2fApduCommand::CreateRegister(app_param, challenge_param);
   if (!register_cmd) {
     callback.Run(U2fReturnCode::INVALID_PARAMS, std::vector<uint8_t>());
     return;
   }
-  DeviceTransact(std::move(register_cmd),
-                 base::Bind(&U2fDevice::OnRegisterComplete,
-                            weak_factory_.GetWeakPtr(), callback));
+  DeviceTransact(
+      std::move(register_cmd),
+      base::Bind(&U2fDevice::OnRegisterComplete, GetWeakPtr(), callback));
 }
 
 void U2fDevice::Sign(const std::vector<uint8_t>& app_param,
                      const std::vector<uint8_t>& challenge_param,
                      const std::vector<uint8_t>& key_handle,
                      const MessageCallback& callback) {
   std::unique_ptr<U2fApduCommand> sign_cmd =
       U2fApduCommand::CreateSign(app_param, challenge_param, key_handle);
   if (!sign_cmd) {
     callback.Run(U2fReturnCode::INVALID_PARAMS, std::vector<uint8_t>());
     return;
   }
-  DeviceTransact(std::move(sign_cmd),
-                 base::Bind(&U2fDevice::OnSignComplete,
-                            weak_factory_.GetWeakPtr(), callback));
+  DeviceTransact(std::move(sign_cmd), base::Bind(&U2fDevice::OnSignComplete,
+                                                 GetWeakPtr(), callback));
 }
 
 void U2fDevice::Version(const VersionCallback& callback) {
   std::unique_ptr<U2fApduCommand> version_cmd = U2fApduCommand::CreateVersion();
   if (!version_cmd) {
     callback.Run(false, ProtocolVersion::UNKNOWN);
     return;
   }
-  DeviceTransact(std::move(version_cmd),
-                 base::Bind(&U2fDevice::OnVersionComplete,
-                            weak_factory_.GetWeakPtr(), callback));
+  DeviceTransact(
+      std::move(version_cmd),
+      base::Bind(&U2fDevice::OnVersionComplete, GetWeakPtr(), callback));
 }
 
 void U2fDevice::OnRegisterComplete(
     const MessageCallback& callback,
     bool success,
     std::unique_ptr<U2fApduResponse> register_response) {
   if (!success || !register_response) {
     callback.Run(U2fReturnCode::FAILURE, std::vector<uint8_t>());
     return;
   }
@@ skipping 60 matching lines @@
           U2fApduResponse::Status::SW_NO_ERROR &&
       legacy_version_response->data() ==
           std::vector<uint8_t>({'U', '2', 'F', '_', 'V', '2'})) {
     callback.Run(success, ProtocolVersion::U2F_V2);
     return;
   }
   callback.Run(success, ProtocolVersion::UNKNOWN);
 }
 
 }  // namespace device