Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2841993002: Revert of [snapshot] full setup delegate should also be able to deserialize. (Closed)

Created:
3 years, 8 months ago by Michael Hablich
Modified:
3 years, 8 months ago
Reviewers:
Yang, Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [snapshot] full setup delegate should also be able to deserialize. (patchset #2 id:20001 of https://codereview.chromium.org/2840493002/ ) Reason for revert: prime suspect for https://bugs.chromium.org/p/chromium/issues/detail?id=714976 Original issue's description: > [snapshot] full setup delegate should also be able to deserialize. > > Also move the responsibility of marking builtins as initialized > to the deserializer. > > R=jkummerow@chromium.org > > Review-Url: https://codereview.chromium.org/2840493002 > Cr-Commit-Position: refs/heads/master@{#44802} > Committed: https://chromium.googlesource.com/v8/v8/+/a2b3a2fbc562584ec298dfe674c97662a125a59e TBR=jkummerow@chromium.org,yangguo@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=chromium:714976 Review-Url: https://codereview.chromium.org/2841993002 Cr-Commit-Position: refs/heads/master@{#44870} Committed: https://chromium.googlesource.com/v8/v8/+/6d9ca97cd23dd9bf4c0a29350c2756829f7680c2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -19 lines) Patch
M src/builtins/builtins.h View 2 chunks +5 lines, -6 lines 0 comments Download
M src/setup-isolate.h View 1 chunk +4 lines, -5 lines 0 comments Download
M src/setup-isolate-deserialize.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/setup-isolate-full.cc View 2 chunks +13 lines, -4 lines 0 comments Download
M src/snapshot/deserializer.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M src/snapshot/snapshot.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Michael Hablich
Created Revert of [snapshot] full setup delegate should also be able to deserialize.
3 years, 8 months ago (2017-04-25 19:03:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2841993002/1
3 years, 8 months ago (2017-04-25 19:03:14 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: v8_win_nosnap_shared_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng/builds/21372) v8_win_nosnap_shared_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, ...
3 years, 8 months ago (2017-04-25 19:33:57 UTC) #6
Yang
On 2017/04/25 19:33:57, commit-bot: I haz the power wrote: > Try jobs failed on following ...
3 years, 8 months ago (2017-04-25 19:36:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2841993002/1
3 years, 8 months ago (2017-04-25 19:38:09 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-25 19:54:09 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/6d9ca97cd23dd9bf4c0a29350c2756829f7...

Powered by Google App Engine
This is Rietveld 408576698