Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(972)

Unified Diff: src/setup-isolate.h

Issue 2841993002: Revert of [snapshot] full setup delegate should also be able to deserialize. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/builtins/builtins.h ('k') | src/setup-isolate-deserialize.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/setup-isolate.h
diff --git a/src/setup-isolate.h b/src/setup-isolate.h
index 1cdc9c9e76809e4df89b805641ad4bb97d46e5a9..2e56eaec64a2e374a1f6b2c91bf7d07103f07624 100644
--- a/src/setup-isolate.h
+++ b/src/setup-isolate.h
@@ -16,12 +16,11 @@
// This class is an abstraction layer around initialization of components
// that are either deserialized from the snapshot or generated from scratch.
// Currently this includes builtins and interpreter bytecode handlers.
-// There are two implementations to choose from at link time:
+// There are three implementations to choose from (at link time):
// - setup-isolate-deserialize.cc: always loads things from snapshot.
-// - setup-isolate-full.cc: loads from snapshot or bootstraps from scratch,
-// controlled by the |create_heap_objects| flag.
-// For testing, the implementation in setup-isolate-for-tests.cc can be chosen
-// to force the behavior of setup-isolate-full.cc at runtime.
+// - setup-isolate-full.cc: always generates things.
+// - setup-isolate-for-tests.cc: does the one or the other, controlled by
+// the |create_heap_objects| flag.
//
// The actual implementations of generation of builtins and handlers is in
// setup-builtins-internal.cc and setup-interpreter-internal.cc, and is
« no previous file with comments | « src/builtins/builtins.h ('k') | src/setup-isolate-deserialize.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698