[snapshot] full setup delegate should also be able to deserialize.

[snapshot] full setup delegate should also be able to deserialize.

Also move the responsibility of marking builtins as initialized
to the deserializer.

R=jkummerow@chromium.org

Review-Url: https://codereview.chromium.org/2840493002
Cr-Original-Commit-Position: refs/heads/master@{#44802}
Committed: https://chromium.googlesource.com/v8/v8/+/a2b3a2fbc562584ec298dfe674c97662a125a59e
Review-Url: https://codereview.chromium.org/2840493002
Cr-Commit-Position: refs/heads/master@{#44884}
Committed: https://chromium.googlesource.com/v8/v8/+/2e23a0eca425f589b5a569fe83e417eea7e7fb8f

[Yang, 2017-04-24 07:01:38]

The CQ bit was checked by yangguo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-24 07:01:43]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-24 07:26:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-24 07:26:57]

Dry run: This issue passed the CQ dry run.

[Jakob Kummerow, 2017-04-24 13:19:08]

LGTM with nits.

https://codereview.chromium.org/2840493002/diff/1/src/builtins/builtins.h
File src/builtins/builtins.h (right):

https://codereview.chromium.org/2840493002/diff/1/src/builtins/builtins.h#new...
src/builtins/builtins.h:152: friend class SetupIsolateDelegate;
You don't need this anymore.

https://codereview.chromium.org/2840493002/diff/1/src/setup-isolate.h
File src/setup-isolate.h (right):

https://codereview.chromium.org/2840493002/diff/1/src/setup-isolate.h#newcode21
src/setup-isolate.h:21: // - setup-isolate-full.cc: does the one or the other,
controlled by
nit: s/does the one or the other/loads from snapshot or bootstraps from scratch/

[Yang, 2017-04-24 13:29:03]

https://codereview.chromium.org/2840493002/diff/1/src/builtins/builtins.h
File src/builtins/builtins.h (right):

https://codereview.chromium.org/2840493002/diff/1/src/builtins/builtins.h#new...
src/builtins/builtins.h:152: friend class SetupIsolateDelegate;
On 2017/04/24 13:19:07, Jakob Kummerow wrote:
> You don't need this anymore.

As discussed offline, we still need this for the builtins_ field.

https://codereview.chromium.org/2840493002/diff/1/src/setup-isolate.h
File src/setup-isolate.h (right):

https://codereview.chromium.org/2840493002/diff/1/src/setup-isolate.h#newcode21
src/setup-isolate.h:21: // - setup-isolate-full.cc: does the one or the other,
controlled by
On 2017/04/24 13:19:07, Jakob Kummerow wrote:
> nit: s/does the one or the other/loads from snapshot or bootstraps from
scratch/

Done.

[Yang, 2017-04-24 13:29:06]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2017-04-24 13:29:07]

The patchset sent to the CQ was uploaded after l-g-t-m from
jkummerow@chromium.org
Link to the patchset: https://codereview.chromium.org/2840493002/#ps20001
(title: "fix comment")

[commit-bot: I haz the power, 2017-04-24 13:29:16]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-24 13:57:43]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493040546942230,
"parent_rev": "2f8cae53f8e29980337ba5c111a05ac66bb882cc", "commit_rev":
"a2b3a2fbc562584ec298dfe674c97662a125a59e"}

[commit-bot: I haz the power, 2017-04-24 13:57:47]

Description was changed from

==========
[snapshot] full setup delegate should also be able to deserialize.

Also move the responsibility of marking builtins as initialized
to the deserializer.

R=jkummerow@chromium.org
==========

to

==========
[snapshot] full setup delegate should also be able to deserialize.

Also move the responsibility of marking builtins as initialized
to the deserializer.

R=jkummerow@chromium.org

Review-Url: https://codereview.chromium.org/2840493002
Cr-Commit-Position: refs/heads/master@{#44802}
Committed:
https://chromium.googlesource.com/v8/v8/+/a2b3a2fbc562584ec298dfe674c97662a12...
==========

[commit-bot: I haz the power, 2017-04-24 13:57:48]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/a2b3a2fbc562584ec298dfe674c97662a12...

[Michael Hablich, 2017-04-25 19:03:06]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2841993002/ by hablich@chromium.org.

The reason for reverting is: prime suspect for
https://bugs.chromium.org/p/chromium/issues/detail?id=714976.

[Yang, 2017-04-25 19:44:19]

Description was changed from

==========
[snapshot] full setup delegate should also be able to deserialize.

Also move the responsibility of marking builtins as initialized
to the deserializer.

R=jkummerow@chromium.org

Review-Url: https://codereview.chromium.org/2840493002
Cr-Commit-Position: refs/heads/master@{#44802}
Committed:
https://chromium.googlesource.com/v8/v8/+/a2b3a2fbc562584ec298dfe674c97662a12...
==========

to

==========
[snapshot] full setup delegate should also be able to deserialize.

Also move the responsibility of marking builtins as initialized
to the deserializer.

R=jkummerow@chromium.org

Review-Url: https://codereview.chromium.org/2840493002
Cr-Commit-Position: refs/heads/master@{#44802}
Committed:
https://chromium.googlesource.com/v8/v8/+/a2b3a2fbc562584ec298dfe674c97662a12...
==========

[Yang, 2017-04-26 10:18:47]

The CQ bit was checked by yangguo@chromium.org

[commit-bot: I haz the power, 2017-04-26 10:18:58]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-26 10:44:45]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493201927417490,
"parent_rev": "9c47a061cf325addf8bd2ba4b71a4d1ef210c5d6", "commit_rev":
"2e23a0eca425f589b5a569fe83e417eea7e7fb8f"}

[commit-bot: I haz the power, 2017-04-26 10:44:52]

Description was changed from

==========
[snapshot] full setup delegate should also be able to deserialize.

Also move the responsibility of marking builtins as initialized
to the deserializer.

R=jkummerow@chromium.org

Review-Url: https://codereview.chromium.org/2840493002
Cr-Commit-Position: refs/heads/master@{#44802}
Committed:
https://chromium.googlesource.com/v8/v8/+/a2b3a2fbc562584ec298dfe674c97662a12...
==========

to

==========
[snapshot] full setup delegate should also be able to deserialize.

Also move the responsibility of marking builtins as initialized
to the deserializer.

R=jkummerow@chromium.org

Review-Url: https://codereview.chromium.org/2840493002
Cr-Original-Commit-Position: refs/heads/master@{#44802}
Committed:
https://chromium.googlesource.com/v8/v8/+/a2b3a2fbc562584ec298dfe674c97662a12...
Review-Url: https://codereview.chromium.org/2840493002
Cr-Commit-Position: refs/heads/master@{#44884}
Committed:
https://chromium.googlesource.com/v8/v8/+/2e23a0eca425f589b5a569fe83e417eea7e...
==========

[commit-bot: I haz the power, 2017-04-26 10:44:53]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/2e23a0eca425f589b5a569fe83e417eea7e...