Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 2841493003: Web MIDI: remove old Windows backend (Closed)

Created:
3 years, 8 months ago by Takashi Toyoshima
Modified:
3 years, 8 months ago
Reviewers:
yukawa, yhirano
CC:
chromium-reviews, feature-media-reviews_chromium.org, toyoshim+midi_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Web MIDI: remove old Windows backend The new backend supporting dynamic instantiation on Windows was rolled out to the stable channel via a field trial flag. This new backend solves some long-living problems, e.g., grabbing devices forever, battery concerns, and stability. Since the feature was enabled by default, and have worked well, I want to remove the old backend now. Another change that renames new backend will follow. BUG=672793 Review-Url: https://codereview.chromium.org/2841493003 Cr-Commit-Position: refs/heads/master@{#466904} Committed: https://chromium.googlesource.com/chromium/src/+/4399414ef40580162c65f96e76b4055edbc6e590

Patch Set 1 #

Patch Set 2 : owners update #

Total comments: 2

Patch Set 3 : revert renaming #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -1296 lines) Patch
M media/midi/BUILD.gn View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M media/midi/OWNERS View 1 1 chunk +3 lines, -3 lines 0 comments Download
D media/midi/dynamically_initialized_midi_manager_win.cc View 1 2 2 chunks +10 lines, -0 lines 0 comments Download
M media/midi/midi_manager_win.h View 1 2 1 chunk +0 lines, -79 lines 0 comments Download
M media/midi/midi_manager_win.cc View 1 2 1 chunk +0 lines, -1212 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 21 (14 generated)
Takashi Toyoshima
yhirano, can you review this mechanical change to remove old backend? fyi, yukawa, and probably ...
3 years, 8 months ago (2017-04-24 09:30:24 UTC) #5
Takashi Toyoshima
chat with yhirano offline. I will land the switch change of 2835083002 first. This change ...
3 years, 8 months ago (2017-04-24 10:22:18 UTC) #6
Takashi Toyoshima
ptal ps4
3 years, 8 months ago (2017-04-24 11:59:00 UTC) #12
yhirano
LGTM
3 years, 8 months ago (2017-04-25 02:21:36 UTC) #15
Takashi Toyoshima
will submit. Yukawa-san, please feel free to ping me to revisit OWNERS changes, and so ...
3 years, 8 months ago (2017-04-25 06:04:50 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2841493003/60001
3 years, 8 months ago (2017-04-25 06:05:10 UTC) #18
commit-bot: I haz the power
3 years, 8 months ago (2017-04-25 06:52:19 UTC) #21
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/4399414ef40580162c65f96e76b4...

Powered by Google App Engine
This is Rietveld 408576698