Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 2834423002: Web MIDI: rename DynamicallyInitializedMidiManagerWin (Closed)

Created:
3 years, 8 months ago by Takashi Toyoshima
Modified:
3 years, 8 months ago
Reviewers:
yhirano
CC:
chromium-reviews, feature-media-reviews_chromium.org, toyoshim+midi_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Web MIDI: rename DynamicallyInitializedMidiManagerWin Since the old backend was already removed, rename the new backend DynamicallyInitializedMidiManagerWin to MidiManagerWin. BUG=672793 Review-Url: https://codereview.chromium.org/2834423002 Cr-Commit-Position: refs/heads/master@{#466980} Committed: https://chromium.googlesource.com/chromium/src/+/60350512cce320ab73d0f1275fdd164cba5a37e7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -1089 lines) Patch
M media/midi/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
D media/midi/dynamically_initialized_midi_manager_win.h View 1 chunk +0 lines, -101 lines 0 comments Download
D media/midi/dynamically_initialized_midi_manager_win.cc View 1 chunk +0 lines, -865 lines 0 comments Download
A + media/midi/midi_manager_win.h View 4 chunks +8 lines, -8 lines 0 comments Download
A + media/midi/midi_manager_win.cc View 21 chunks +90 lines, -113 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (9 generated)
Takashi Toyoshima
this will follow the first removing patch
3 years, 8 months ago (2017-04-24 11:58:29 UTC) #5
yhirano
lgtm
3 years, 8 months ago (2017-04-25 02:23:51 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2834423002/1
3 years, 8 months ago (2017-04-25 11:47:19 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-25 14:20:27 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/60350512cce320ab73d0f1275fdd...

Powered by Google App Engine
This is Rietveld 408576698