Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Issue 2835083002: Web MIDI dynamic instantiation experiment-controlled rollouts: step 4 (Closed)

Created:
3 years, 8 months ago by Takashi Toyoshima
Modified:
3 years, 8 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, toyoshim+midi_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Web MIDI dynamic instantiation experiment-controlled rollouts: step 4 Enable dynamic instantiation mode by default on Linux, ChromeOS, and Windows. Other platforms still need to rely on the existing experiment-controlled flag and will be launched separately. BUG=672793, 714511 Review-Url: https://codereview.chromium.org/2835083002 Cr-Commit-Position: refs/heads/master@{#466881} Committed: https://chromium.googlesource.com/chromium/src/+/3793199ef338f7a3f19ba5d6d35ceb8ba63c8f33

Patch Set 1 #

Patch Set 2 : nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M media/midi/midi_service.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (9 generated)
Takashi Toyoshima
ptal
3 years, 8 months ago (2017-04-24 06:27:11 UTC) #4
Alexei Svitkine (slow)
lgtm
3 years, 8 months ago (2017-04-24 15:01:38 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2835083002/20001
3 years, 8 months ago (2017-04-25 02:33:48 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-25 05:21:06 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/3793199ef338f7a3f19ba5d6d35c...

Powered by Google App Engine
This is Rietveld 408576698