third_party/WebKit/Source/core/layout/LayoutBox.cpp - Issue 2841353002: Split initial methods of (/max/min)(width/height) on ComputedStyle.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBox.cpp

Issue 2841353002: Split initial methods of (/max/min)(width/height) on ComputedStyle. (Closed)

Patch Set: gco rename-style-box && gut Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutBox.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutBox.cpp b/third_party/WebKit/Source/core/layout/LayoutBox.cpp

index 6f2ceee06cd38b7eebf8828ca9cde565f9b1a570..c801ec96e5cbfc8cffdf26662a4ebc85873f6c69 100644

--- a/third_party/WebKit/Source/core/layout/LayoutBox.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutBox.cpp

@@ -3517,8 +3517,8 @@ bool LayoutBox::LogicalHeightComputesAsNone(SizeType size_type) const {

Length logical_height = size_type == kMinSize ? Style()->LogicalMinHeight()

: Style()->LogicalMaxHeight();

Length initial_logical_height = size_type == kMinSize

- ? ComputedStyle::InitialMinSize()

- : ComputedStyle::InitialMaxSize();

+ ? ComputedStyle::InitialMinHeight()

+ : ComputedStyle::InitialMaxHeight();

if (logical_height == initial_logical_height)

return true;