Handle |public| in check_gn_headers.py

Handle |public| in check_gn_headers.py

If |public| of a target contains files, count them as recognized
headers as well.

BUG=661774
Review-Url: https://codereview.chromium.org/2841323003
Cr-Commit-Position: refs/heads/master@{#467826}
Committed: https://chromium.googlesource.com/chromium/src/+/5523578be7767b76e2eff354c98a82dcd8f653b5

[wychen, 2017-04-27 06:24:20]

Description was changed from

==========
Handle |public| in check_gn_headers.py

If |public| of a target contains files, count them as recognized
headers as well.

BUG=661774
==========

to

==========
Handle |public| in check_gn_headers.py

If |public| of a target contains files, count them as recognized
headers as well.

BUG=661774
==========

[wychen, 2017-04-27 06:24:20]

wychen@chromium.org changed reviewers:
+ thakis@chromium.org

[wychen, 2017-04-27 07:05:33]

PTAL

[Nico, 2017-04-27 14:14:50]

https://codereview.chromium.org/2841323003/diff/1/build/check_gn_headers.py
File build/check_gn_headers.py (right):

https://codereview.chromium.org/2841323003/diff/1/build/check_gn_headers.py#n...
build/check_gn_headers.py:81: if type(public) is list:
isn't that always true?

[wychen, 2017-04-27 16:20:57]

https://codereview.chromium.org/2841323003/diff/1/build/check_gn_headers.py
File build/check_gn_headers.py (right):

https://codereview.chromium.org/2841323003/diff/1/build/check_gn_headers.py#n...
build/check_gn_headers.py:81: if type(public) is list:
On 2017/04/27 14:14:50, Nico wrote:
> isn't that always true?

It could be "*" in some cases. I'll add this in the comment.

[Nico, 2017-04-27 16:25:11]

lgtm with that comment

[wychen, 2017-04-27 22:44:02]

The CQ bit was checked by wychen@chromium.org

[wychen, 2017-04-27 22:44:02]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/2841323003/#ps40001
(title: "add tests")

[commit-bot: I haz the power, 2017-04-27 22:45:00]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-28 01:59:20]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1493333042016050,
"parent_rev": "7a56b3cd2544600bce3b0f3df38eba2c06eb0dfe", "commit_rev":
"5523578be7767b76e2eff354c98a82dcd8f653b5"}

[commit-bot: I haz the power, 2017-04-28 01:59:30]

Description was changed from

==========
Handle |public| in check_gn_headers.py

If |public| of a target contains files, count them as recognized
headers as well.

BUG=661774
==========

to

==========
Handle |public| in check_gn_headers.py

If |public| of a target contains files, count them as recognized
headers as well.

BUG=661774

Review-Url: https://codereview.chromium.org/2841323003
Cr-Commit-Position: refs/heads/master@{#467826}
Committed:
https://chromium.googlesource.com/chromium/src/+/5523578be7767b76e2eff354c98a...
==========

[commit-bot: I haz the power, 2017-04-28 01:59:31]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/5523578be7767b76e2eff354c98a...