Handle |public| in check_gn_headers.py

build/check_gn_headers.py

 #!/usr/bin/env python
 # Copyright 2017 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Find header files missing in GN.
 
 This script gets all the header files from ninja_deps, which is from the true
 dependency generated by the compiler, and report if they don't exist in GN.
 """
@@ skipping 58 matching lines @@
   subprocess.check_call(['gn', 'gen', out_dir, '--ide=json', '-q'])
   gn_json = json.load(open(os.path.join(out_dir, 'project.json')))
   q.put(ParseGNProjectJSON(gn_json))
 
 
 def ParseGNProjectJSON(gn):
   """Parse GN output and get the header files"""
   all_headers = set()
 
   for _target, properties in gn['targets'].iteritems():
-    for f in properties.get('sources', []):
+    sources = properties.get('sources', [])
+    public = properties.get('public', [])
+    if type(public) is list:

[Nico, 2017/04/27 14:14:50]

isn't that always true?

[wychen, 2017/04/27 16:20:56]

It could be "*" in some cases. I'll add this in the comment.

+      sources += public
+    for f in sources:
       if f.endswith('.h') or f.endswith('.hh'):
         if f.startswith('//'):
           f = f[2:]  # Strip the '//' prefix.
           all_headers.add(f)
 
   return all_headers
 
 
 def GetDepsPrefixes(q):
   """Return all the folders controlled by DEPS file"""
@@ skipping 63 matching lines @@
     return 0
 
   print 'The following files should be included in gn files:'
   for i in missing:
     print i
   return 1
 
 
 if __name__ == '__main__':
   sys.exit(main())