Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Unified Diff: build/check_gn_headers_unittest.py

Issue 2841323003: Handle |public| in check_gn_headers.py (Closed)
Patch Set: add tests Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/check_gn_headers.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/check_gn_headers_unittest.py
diff --git a/build/check_gn_headers_unittest.py b/build/check_gn_headers_unittest.py
index f62fe62309548d5c53803a0e2c6791e29c7cb668..892fa6613e39a74d127a11c536462e244e70dfa1 100755
--- a/build/check_gn_headers_unittest.py
+++ b/build/check_gn_headers_unittest.py
@@ -38,8 +38,14 @@ gn_input = json.loads(r'''
"//:All": {
},
"//:base": {
+ "public": [ "//base/p.h" ],
"sources": [ "//base/a.cc", "//base/a.h", "//base/b.hh" ],
"visibility": [ "*" ]
+ },
+ "//:star_public": {
+ "public": "*",
+ "sources": [ "//base/c.h" ],
+ "visibility": [ "*" ]
}
}
}
@@ -88,6 +94,8 @@ class CheckGnHeadersTest(unittest.TestCase):
expected = set([
'base/a.h',
'base/b.hh',
+ 'base/c.h',
+ 'base/p.h',
])
self.assertEquals(headers, expected)
« no previous file with comments | « build/check_gn_headers.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698