Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1484)

Issue 2841113003: [Offline pages] Addressing TODOs in RemoveRequestTask (Closed)

Created:
3 years, 7 months ago by fgorski
Modified:
3 years, 7 months ago
Reviewers:
Pete Williamson
CC:
chromium-reviews, romax+watch_chromium.org, fgorski+watch_chromium.org, dewittj+watch_chromium.org, petewil+watch_chromium.org, chili+watch_chromium.org, dimich+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Offline pages] Addressing TODOs in RemoveRequestTask Replacing a TODO with actual store state. BUG=714256 R=petewil@chromium.org Review-Url: https://codereview.chromium.org/2841113003 Cr-Commit-Position: refs/heads/master@{#468166} Committed: https://chromium.googlesource.com/chromium/src/+/a396a09fc66ad70d5b12e0466d49e8670104b20b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M components/offline_pages/core/background/remove_requests_task.h View 1 chunk +0 lines, -1 line 0 comments Download
M components/offline_pages/core/background/remove_requests_task.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
fgorski
PTAL
3 years, 7 months ago (2017-04-26 17:56:17 UTC) #1
Pete Williamson
lgtm
3 years, 7 months ago (2017-04-28 20:49:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2841113003/1
3 years, 7 months ago (2017-04-28 20:50:30 UTC) #8
commit-bot: I haz the power
3 years, 7 months ago (2017-04-28 22:49:06 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a396a09fc66ad70d5b12e0466d49...

Powered by Google App Engine
This is Rietveld 408576698