components/offline_pages/core/background/remove_requests_task.h - Issue 2841113003: [Offline pages] Addressing TODOs in RemoveRequestTask

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/offline_pages/core/background/remove_requests_task.h

Issue 2841113003: [Offline pages] Addressing TODOs in RemoveRequestTask (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/offline_pages/core/background/remove_requests_task.h

diff --git a/components/offline_pages/core/background/remove_requests_task.h b/components/offline_pages/core/background/remove_requests_task.h

index 6372d3d1822e7ee204b068ca4a79d5a84a90a24a..19b55438660d161551b2f462e6afd83edebe2067 100644

--- a/components/offline_pages/core/background/remove_requests_task.h

+++ b/components/offline_pages/core/background/remove_requests_task.h

@@ -38,7 +38,6 @@ class RemoveRequestsTask : public Task {

// Store that this task updates.

RequestQueueStore* store_;

// Request IDs to be updated.

- // TODO(fgorski): perhaps convert to unique_ptr to a vector.

std::vector<int64_t> request_ids_;

// Callback to complete the task.

RequestQueueStore::UpdateCallback callback_;

« no previous file with comments | « no previous file | components/offline_pages/core/background/remove_requests_task.cc » ('j') | no next file with comments »