Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Unified Diff: components/offline_pages/core/background/remove_requests_task.cc

Issue 2841113003: [Offline pages] Addressing TODOs in RemoveRequestTask (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/offline_pages/core/background/remove_requests_task.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/offline_pages/core/background/remove_requests_task.cc
diff --git a/components/offline_pages/core/background/remove_requests_task.cc b/components/offline_pages/core/background/remove_requests_task.cc
index f958e6708149f1338d316f3d19f79958cc83abf3..a18d31aeed58ed57c524c80449211f6feddc0470 100644
--- a/components/offline_pages/core/background/remove_requests_task.cc
+++ b/components/offline_pages/core/background/remove_requests_task.cc
@@ -35,9 +35,8 @@ void RemoveRequestsTask::RemoveRequests() {
}
void RemoveRequestsTask::CompleteEarly(ItemActionStatus status) {
- // TODO(fgorski): store_->state() once implemented
std::unique_ptr<UpdateRequestsResult> result(
- new UpdateRequestsResult(StoreState::LOADED));
+ new UpdateRequestsResult(store_->state()));
for (int64_t request_id : request_ids_)
result->item_statuses.push_back(std::make_pair(request_id, status));
CompleteWithResult(std::move(result));
« no previous file with comments | « components/offline_pages/core/background/remove_requests_task.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698