chrome/browser/extensions/external_install_ui.cc - Issue 284103002: Replace "external_install" boolean parameter with explicit enumeration in ExtensionUninstall method.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/external_install_ui.cc

Issue 284103002: Replace "external_install" boolean parameter with explicit enumeration in ExtensionUninstall method. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/extension_service.cc ('K') | « chrome/browser/extensions/extension_sync_service.cc ('k') | chrome/browser/extensions/shared_module_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/external_install_ui.cc

diff --git a/chrome/browser/extensions/external_install_ui.cc b/chrome/browser/extensions/external_install_ui.cc

index 18321849b877eba83b28b2e7855622112b2822da..c2aaeca47eb7b468af8e35b3bf68c96aca94a60d 100644

--- a/chrome/browser/extensions/external_install_ui.cc

+++ b/chrome/browser/extensions/external_install_ui.cc

@@ -342,7 +342,8 @@ void ExternalInstallDialogDelegate::InstallUIAbort(bool user_initiated) {

const Extension* extension = NULL;

if (service_weak_.get() &&

(extension = service_weak_->GetInstalledExtension(extension_id_))) {

- service_weak_->UninstallExtension(extension_id_, false, NULL);

+ service_weak_->UninstallExtension(

+ extension_id_, ExtensionService::kUninstallReasonDefault, NULL);

Devlin 2014/05/14 23:14:20 I don't think that external_install_ui and extensi

rpaquay 2014/06/30 23:16:18 Done.

}

Release();

}