Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5172)

Unified Diff: chrome/browser/extensions/extension_sync_service.cc

Issue 284103002: Replace "external_install" boolean parameter with explicit enumeration in ExtensionUninstall method. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_sync_service.cc
diff --git a/chrome/browser/extensions/extension_sync_service.cc b/chrome/browser/extensions/extension_sync_service.cc
index 7dbe61398620e9c4f501402ea160bd4ed24f164f..a87d855559c9008c97ffaee274ea1f4e66dba103 100644
--- a/chrome/browser/extensions/extension_sync_service.cc
+++ b/chrome/browser/extensions/extension_sync_service.cc
@@ -444,7 +444,10 @@ bool ExtensionSyncService::ProcessExtensionSyncDataHelper(
// Handle uninstalls first.
if (extension_sync_data.uninstalled()) {
- if (!extension_service_->UninstallExtensionHelper(extension_service_, id)) {
+ if (!extension_service_->UninstallExtensionHelper(
+ extension_service_,
+ id,
+ ExtensionService::kUninstallReasonSynch)) {
LOG(WARNING) << "Could not uninstall extension " << id
<< " for sync";
}

Powered by Google App Engine
This is Rietveld 408576698