Replace "external_install" boolean parameter with explicit enumeration in ExtensionUninstall method.

chrome/browser/extensions/external_install_ui.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/external_install_ui.h"
 
 #include <string>
 
 #include "base/bind.h"
 #include "base/lazy_instance.h"
@@ skipping 324 matching lines @@
       (extension = service_weak_->GetInstalledExtension(extension_id_))) {
     service_weak_->GrantPermissionsAndEnableExtension(extension);
   }
   Release();
 }
 
 void ExternalInstallDialogDelegate::InstallUIAbort(bool user_initiated) {
   const Extension* extension = NULL;
   if (service_weak_.get() &&
       (extension = service_weak_->GetInstalledExtension(extension_id_))) {
-    service_weak_->UninstallExtension(extension_id_, false, NULL);
+    service_weak_->UninstallExtension(
+        extension_id_, ExtensionService::kUninstallReasonDefault, NULL);

[Devlin, 2014/05/14 23:14:20]

I don't think that external_install_ui and extension_disabled_ui should have
different reasons.  They are very similar in nature.

[rpaquay, 2014/06/30 23:16:18]

Done.

   }
   Release();
 }
 
 // ExternalInstallMenuAlert -------------------------------------------------
 
 ExternalInstallMenuAlert::ExternalInstallMenuAlert(ExtensionService* service,
                                                    const Extension* extension)
     : service_(service),
       extension_(extension),
@@ skipping 218 matching lines @@
 
 bool HasExternalInstallBubble(ExtensionService* service) {
   GlobalErrorService* error_service =
       GlobalErrorServiceFactory::GetForProfile(service->profile());
   GlobalError* error = error_service->GetGlobalErrorByMenuItemCommandID(
       kMenuCommandId);
   return error && error->HasBubbleView();
 }
 
 }  // namespace extensions