Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1985)

Unified Diff: chrome/browser/extensions/shared_module_service.cc

Issue 284103002: Replace "external_install" boolean parameter with explicit enumeration in ExtensionUninstall method. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/shared_module_service.cc
diff --git a/chrome/browser/extensions/shared_module_service.cc b/chrome/browser/extensions/shared_module_service.cc
index 78e9ab74e21c6c06c95f8661e9c110e776fb5aea..9de170a23bbdfd9cdd3930c802cf1b282bd78f40 100644
--- a/chrome/browser/extensions/shared_module_service.cc
+++ b/chrome/browser/extensions/shared_module_service.cc
@@ -153,9 +153,10 @@ void SharedModuleService::PruneSharedModulesOnUninstall(
scoped_ptr<const ExtensionSet> dependents =
GetDependentExtensions(imported_module);
if (dependents->is_empty()) {
- service->UninstallExtension(iter->extension_id,
- true, // External uninstall.
- NULL); // Ignore error.
+ service->UninstallExtension(
+ iter->extension_id,
+ ExtensionService::kUninstallReasonOrphanedSharedModule,
+ NULL); // Ignore error.
}
}
}

Powered by Google App Engine
This is Rietveld 408576698