chrome/browser/ui/cocoa/apps/app_shim_menu_controller_mac_browsertest.mm - Issue 284103002: Replace "external_install" boolean parameter with explicit enumeration in ExtensionUninstall method.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/apps/app_shim_menu_controller_mac_browsertest.mm

Issue 284103002: Replace "external_install" boolean parameter with explicit enumeration in ExtensionUninstall method. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address issue exposed by failing unit test. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/browser_browsertest.cc ('k') | chrome/browser/ui/cocoa/extensions/extension_action_context_menu_controller.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/apps/app_shim_menu_controller_mac_browsertest.mm

diff --git a/chrome/browser/ui/cocoa/apps/app_shim_menu_controller_mac_browsertest.mm b/chrome/browser/ui/cocoa/apps/app_shim_menu_controller_mac_browsertest.mm

index 21daa372bbcd76616d4a362c1772107c6de690d3..c9db22cfba3a9c8b6220a14f2e6000d31e62c936 100644

--- a/chrome/browser/ui/cocoa/apps/app_shim_menu_controller_mac_browsertest.mm

+++ b/chrome/browser/ui/cocoa/apps/app_shim_menu_controller_mac_browsertest.mm

@@ -147,7 +147,10 @@ IN_PROC_BROWSER_TEST_F(AppShimMenuControllerBrowserTest,

object:app_1_app_window->GetNativeWindow()];

CheckHasAppMenus(app_1_);

- ExtensionService::UninstallExtensionHelper(extension_service(), app_1_->id());

+ ExtensionService::UninstallExtensionHelper(

+ extension_service(),

+ app_1_->id(),

+ ExtensionService::UNINSTALL_REASON_FOR_TESTING);

CheckNoAppMenus();

}