Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5902)

Unified Diff: chrome/browser/ui/browser_browsertest.cc

Issue 284103002: Replace "external_install" boolean parameter with explicit enumeration in ExtensionUninstall method. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address issue exposed by failing unit test. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/browser_browsertest.cc
diff --git a/chrome/browser/ui/browser_browsertest.cc b/chrome/browser/ui/browser_browsertest.cc
index a33a737996c29353507030cd69f8966295faddcf..a4bb7b2f09dacef1f537f85aa725924c26c28b48 100644
--- a/chrome/browser/ui/browser_browsertest.cc
+++ b/chrome/browser/ui/browser_browsertest.cc
@@ -1307,7 +1307,9 @@ IN_PROC_BROWSER_TEST_F(BrowserTest, MAYBE_TabClosingWhenRemovingExtension) {
// Uninstall the extension and make sure TabClosing is sent.
ExtensionService* service = extensions::ExtensionSystem::Get(
browser()->profile())->extension_service();
- service->UninstallExtension(GetExtension()->id(), false, NULL);
+ service->UninstallExtension(GetExtension()->id(),
+ ExtensionService::UNINSTALL_REASON_FOR_TESTING,
+ NULL);
EXPECT_EQ(1, observer.closing_count());
model->RemoveObserver(&observer);

Powered by Google App Engine
This is Rietveld 408576698