chrome/browser/ui/cocoa/extensions/extension_action_context_menu_controller.mm - Issue 284103002: Replace "external_install" boolean parameter with explicit enumeration in ExtensionUninstall method.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/extensions/extension_action_context_menu_controller.mm

Issue 284103002: Replace "external_install" boolean parameter with explicit enumeration in ExtensionUninstall method. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address issue exposed by failing unit test. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/apps/app_shim_menu_controller_mac_browsertest.mm ('k') | chrome/browser/ui/views/apps/app_info_dialog/app_info_footer_panel.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/extensions/extension_action_context_menu_controller.mm

diff --git a/chrome/browser/ui/cocoa/extensions/extension_action_context_menu_controller.mm b/chrome/browser/ui/cocoa/extensions/extension_action_context_menu_controller.mm

index 9824eaecd32ea1647a26161c20c68ae4e43a8c21..1ef4a5034ee6e86bb1e3948ca065225333679e43 100644

--- a/chrome/browser/ui/cocoa/extensions/extension_action_context_menu_controller.mm

+++ b/chrome/browser/ui/cocoa/extensions/extension_action_context_menu_controller.mm

@@ -52,8 +52,11 @@ class AsyncUninstaller : public extensions::ExtensionUninstallDialog::Delegate {

// ExtensionUninstallDialog::Delegate:

virtual void ExtensionUninstallAccepted() OVERRIDE {

- extensions::ExtensionSystem::Get(profile_)->extension_service()->

- UninstallExtension(extension_->id(), false, NULL);

+ extensions::ExtensionSystem::Get(profile_)

+ ->extension_service()

+ ->UninstallExtension(extension_->id(),

+ ExtensionService::UNINSTALL_REASON_USER_INITIATED,

+ NULL);

}

virtual void ExtensionUninstallCanceled() OVERRIDE {}