chrome/browser/ui/cocoa/apps/app_shim_menu_controller_mac_browsertest.mm - Issue 284103002: Replace "external_install" boolean parameter with explicit enumeration in ExtensionUninstall method.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/cocoa/apps/app_shim_menu_controller_mac_browsertest.mm

Issue 284103002: Replace "external_install" boolean parameter with explicit enumeration in ExtensionUninstall method. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address issue exposed by failing unit test. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/ui/browser_browsertest.cc ('k') | chrome/browser/ui/cocoa/extensions/extension_action_context_menu_controller.mm » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2013 The Chromium Authors. All rights reserved.	1 // Copyright 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #import "chrome/browser/ui/cocoa/apps/app_shim_menu_controller_mac.h"	5 #import "chrome/browser/ui/cocoa/apps/app_shim_menu_controller_mac.h"

6	6

7 #import <Cocoa/Cocoa.h>	7 #import <Cocoa/Cocoa.h>

8	8

9 #include "apps/app_window_registry.h"	9 #include "apps/app_window_registry.h"

10 #include "apps/ui/native_app_window.h"	10 #include "apps/ui/native_app_window.h"

(...skipping 129 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
140 chrome::BrowserIterator()->window()->Close();	140 chrome::BrowserIterator()->window()->Close();

141	141

142 apps::AppWindow* app_1_app_window = apps::AppWindowRegistry::Get(profile())	142 apps::AppWindow* app_1_app_window = apps::AppWindowRegistry::Get(profile())

143 ->GetAppWindowsForApp(app_1_->id())	143 ->GetAppWindowsForApp(app_1_->id())

144 .front();	144 .front();

145 [[NSNotificationCenter defaultCenter]	145 [[NSNotificationCenter defaultCenter]

146 postNotificationName:NSWindowDidBecomeMainNotification	146 postNotificationName:NSWindowDidBecomeMainNotification

147 object:app_1_app_window->GetNativeWindow()];	147 object:app_1_app_window->GetNativeWindow()];

148	148

149 CheckHasAppMenus(app_1_);	149 CheckHasAppMenus(app_1_);

150 ExtensionService::UninstallExtensionHelper(extension_service(), app_1_->id());	150 ExtensionService::UninstallExtensionHelper(

	151 extension_service(),

	152 app_1_->id(),

	153 ExtensionService::UNINSTALL_REASON_FOR_TESTING);

151 CheckNoAppMenus();	154 CheckNoAppMenus();

152 }	155 }

153	156

154 } // namespace	157 } // namespace

OLD	NEW