Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(549)

Issue 2840893002: IndexedDB: Remove DOMStringList special case for transaction() (Closed)

Created:
3 years, 8 months ago by jsbell
Modified:
3 years, 8 months ago
Reviewers:
haraken
CC:
chromium-reviews, blink-reviews, jsbell+idb_chromium.org, cmumford
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

IndexedDB: Remove DOMStringList special case for transaction() Now that sequence conversion handles iterables, we no longer need a special case for IDBDatabase's transaction() method which takes a union of (DOMString or sequence<DOMString>) to accept DOMStringList. The method signature now matches the spec. BUG=674593 TEST=storage/indexeddb/transaction-basics.html Review-Url: https://codereview.chromium.org/2840893002 Cr-Commit-Position: refs/heads/master@{#467188} Committed: https://chromium.googlesource.com/chromium/src/+/0626510c113d95afa8aa15666a81bb25fc7fbda3

Patch Set 1 #

Patch Set 2 : Reparented #

Patch Set 3 : Remove generated files for union type from gni #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -15 lines) Patch
M third_party/WebKit/Source/bindings/modules/v8/generated.gni View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/IDBDatabase.h View 2 chunks +5 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/IDBDatabase.cpp View 2 chunks +1 line, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/IDBDatabase.idl View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/InspectorIndexedDBAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 18 (14 generated)
jsbell
haraken@ - please take a look? (and cq if lg?)
3 years, 8 months ago (2017-04-25 22:07:25 UTC) #10
haraken
LGTM
3 years, 8 months ago (2017-04-26 00:50:18 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2840893002/40001
3 years, 8 months ago (2017-04-26 00:51:13 UTC) #15
commit-bot: I haz the power
3 years, 8 months ago (2017-04-26 00:58:56 UTC) #18
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/0626510c113d95afa8aa15666a81...

Powered by Google App Engine
This is Rietveld 408576698