IndexedDB: Add [SameObject] / [NewObject] annotations per spec

IndexedDB: Add [SameObject] / [NewObject] annotations per spec

A recent spec change [1] to IndexedDB [2] adds the [SameObject] [3] and
[NewObject] [4] IDL extended attributes to properties and methods as
appropiate. These don't change the behavior (which was described by
algorithmic prose) but allow implementations/tests to make additional
assertions about the behavior of the interfaces.

[1] https://github.com/w3c/IndexedDB/commit/05b2a7c5d65a497c49c8636021fc1cc791fdc9c9
[2] https://w3c.github.io/IndexedDB/
[3] https://heycam.github.io/webidl/#SameObject
[4] https://heycam.github.io/webidl/#NewObject

BUG=674593
R=foolip@chromium.org

Review-Url: https://codereview.chromium.org/2837613003
Cr-Commit-Position: refs/heads/master@{#467108}
Committed: https://chromium.googlesource.com/chromium/src/+/ba3e08e72dbeacfc92d01648ac93a72a26257d36

[jsbell, 2017-04-21 19:49:23]

The CQ bit was checked by jsbell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-21 19:49:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-21 21:37:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-21 21:37:11]

Dry run: This issue passed the CQ dry run.

[jsbell, 2017-04-25 18:14:07]

foolip@ - can you take a look? (and cq if lg?)

[foolip, 2017-04-25 18:29:11]

Just my cup of tea, LGTM % nit.

https://codereview.chromium.org/2837613003/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/indexeddb/IDBObjectStore.idl (right):

https://codereview.chromium.org/2837613003/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/indexeddb/IDBObjectStore.idl:44: [NewObject,
NewObject, CallWith=ScriptState, RaisesException] IDBRequest
getAll([Default=Undefined] optional any range,
A very, very new object :)

Maybe search to see if there were more like this I didn't spot.

[jsbell, 2017-04-25 18:39:50]

Ooops, thanks for catching those find/replace-isms.

https://codereview.chromium.org/2837613003/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/indexeddb/IDBObjectStore.idl (right):

https://codereview.chromium.org/2837613003/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/indexeddb/IDBObjectStore.idl:44: [NewObject,
NewObject, CallWith=ScriptState, RaisesException] IDBRequest
getAll([Default=Undefined] optional any range,
On 2017/04/25 18:29:11, foolip_UTC7 wrote:
> A very, very new object :)
> 
> Maybe search to see if there were more like this I didn't spot.

D'oh. There were a couple more up above too.

[jsbell, 2017-04-25 18:39:58]

The CQ bit was checked by jsbell@chromium.org

[jsbell, 2017-04-25 18:39:59]

The patchset sent to the CQ was uploaded after l-g-t-m from foolip@chromium.org
Link to the patchset: https://codereview.chromium.org/2837613003/#ps20001
(title: "Remove extra NewObject annotations")

[commit-bot: I haz the power, 2017-04-25 18:41:10]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-25 21:00:54]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493145598602520,
"parent_rev": "e18d20dc507ec3937a78514d6c45a7fe485f54e9", "commit_rev":
"ba3e08e72dbeacfc92d01648ac93a72a26257d36"}

[commit-bot: I haz the power, 2017-04-25 21:01:02]

Description was changed from

==========
IndexedDB: Add [SameObject] / [NewObject] annotations per spec

A recent spec change [1] to IndexedDB [2] adds the [SameObject] [3] and
[NewObject] [4] IDL extended attributes to properties and methods as
appropiate. These don't change the behavior (which was described by
algorithmic prose) but allow implementations/tests to make additional
assertions about the behavior of the interfaces.

[1]
https://github.com/w3c/IndexedDB/commit/05b2a7c5d65a497c49c8636021fc1cc791fdc9c9
[2] https://w3c.github.io/IndexedDB/
[3] https://heycam.github.io/webidl/#SameObject
[4] https://heycam.github.io/webidl/#NewObject

BUG=674593
R=foolip@chromium.org
==========

to

==========
IndexedDB: Add [SameObject] / [NewObject] annotations per spec

A recent spec change [1] to IndexedDB [2] adds the [SameObject] [3] and
[NewObject] [4] IDL extended attributes to properties and methods as
appropiate. These don't change the behavior (which was described by
algorithmic prose) but allow implementations/tests to make additional
assertions about the behavior of the interfaces.

[1]
https://github.com/w3c/IndexedDB/commit/05b2a7c5d65a497c49c8636021fc1cc791fdc9c9
[2] https://w3c.github.io/IndexedDB/
[3] https://heycam.github.io/webidl/#SameObject
[4] https://heycam.github.io/webidl/#NewObject

BUG=674593
R=foolip@chromium.org

Review-Url: https://codereview.chromium.org/2837613003
Cr-Commit-Position: refs/heads/master@{#467108}
Committed:
https://chromium.googlesource.com/chromium/src/+/ba3e08e72dbeacfc92d01648ac93...
==========

[commit-bot: I haz the power, 2017-04-25 21:01:03]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/ba3e08e72dbeacfc92d01648ac93...