Indexed DB: Remove unnecessary defaults for optional args

Indexed DB: Remove unnecessary defaults for optional args

Blink's bindings generation code didn't used to treat trailing
undefined parameters the same as missing for overload resolution. To
handle getAll(query, undefined) the same as getAll(query) - a
pattern used commonly in parameterized test cases - we specified a
default value for the second parameter in the IDL. That's no longer
necessary, and we can let the overload do that in the implementation.

(The bindings fix happened over a year ago but I missed it!)

R=haraken@chromium.org
BUG=335871
TEST=external/wpt/IndexedDB/idb*_getAll*.html

Review-Url: https://codereview.chromium.org/2837373002
Cr-Commit-Position: refs/heads/master@{#467375}
Committed: https://chromium.googlesource.com/chromium/src/+/458671c24ea47bec9940f1db3034b711a78d5e8c

[jsbell, 2017-04-25 20:16:22]

Description was changed from

==========
Indexed DB: Remove unnecessary defaults for optional args

Blink's bindings generation code didn't use to treat trailing
undefined parameters the same as missing for overload resolition. To
support treating getAll(query, undefined) the same as getAll(query) we
specified a default value for the second parameter in the IDL. That's
no longer necessary, and we can let the overload do that in the
implementation.

(The bindings change happened over a year ago but I missed the memo!)

R=haraken@chromium.org
BUG=335871
==========

to

==========
Indexed DB: Remove unnecessary defaults for optional args

Blink's bindings generation code didn't use to treat trailing
undefined parameters the same as missing for overload resolution. To
support treating getAll(query, undefined) the same as getAll(query) -
a pattern used commonly in parameterized test cases - we specified a
default value for the second parameter in the IDL. That's no longer
necessary, and we can let the overload do that in the implementation.

(The bindings fix happened over a year ago but I missed it!)

R=haraken@chromium.org
BUG=335871
TEST=external/wpt/IndexedDB/idb*_getAll*.html
==========

[jsbell, 2017-04-25 20:16:29]

The CQ bit was checked by jsbell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-25 20:17:06]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-25 21:28:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-25 21:28:15]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[jsbell, 2017-04-25 22:08:40]

The CQ bit was checked by jsbell@chromium.org to run a CQ dry run

[jsbell, 2017-04-25 22:09:20]

Description was changed from

==========
Indexed DB: Remove unnecessary defaults for optional args

Blink's bindings generation code didn't use to treat trailing
undefined parameters the same as missing for overload resolution. To
support treating getAll(query, undefined) the same as getAll(query) -
a pattern used commonly in parameterized test cases - we specified a
default value for the second parameter in the IDL. That's no longer
necessary, and we can let the overload do that in the implementation.

(The bindings fix happened over a year ago but I missed it!)

R=haraken@chromium.org
BUG=335871
TEST=external/wpt/IndexedDB/idb*_getAll*.html
==========

to

==========
Indexed DB: Remove unnecessary defaults for optional args

Blink's bindings generation code didn't used to treat trailing
undefined parameters the same as missing for overload resolution. To
support treating getAll(query, undefined) the same as getAll(query) -
a pattern used commonly in parameterized test cases - we specified a
default value for the second parameter in the IDL. That's no longer
necessary, and we can let the overload do that in the implementation.

(The bindings fix happened over a year ago but I missed it!)

R=haraken@chromium.org
BUG=335871
TEST=external/wpt/IndexedDB/idb*_getAll*.html
==========

[commit-bot: I haz the power, 2017-04-25 22:09:28]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jsbell, 2017-04-25 22:09:59]

Description was changed from

==========
Indexed DB: Remove unnecessary defaults for optional args

Blink's bindings generation code didn't used to treat trailing
undefined parameters the same as missing for overload resolution. To
support treating getAll(query, undefined) the same as getAll(query) -
a pattern used commonly in parameterized test cases - we specified a
default value for the second parameter in the IDL. That's no longer
necessary, and we can let the overload do that in the implementation.

(The bindings fix happened over a year ago but I missed it!)

R=haraken@chromium.org
BUG=335871
TEST=external/wpt/IndexedDB/idb*_getAll*.html
==========

to

==========
Indexed DB: Remove unnecessary defaults for optional args

Blink's bindings generation code didn't used to treat trailing
undefined parameters the same as missing for overload resolution. To
handle getAll(query, undefined) the same as getAll(query) - a
pattern used commonly in parameterized test cases - we specified a
default value for the second parameter in the IDL. That's no longer
necessary, and we can let the overload do that in the implementation.

(The bindings fix happened over a year ago but I missed it!)

R=haraken@chromium.org
BUG=335871
TEST=external/wpt/IndexedDB/idb*_getAll*.html
==========

[jsbell, 2017-04-25 22:10:13]

haraken@ - please take a look? (and cq if lg?)

[commit-bot: I haz the power, 2017-04-26 00:37:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-26 00:37:23]

Dry run: This issue passed the CQ dry run.

[haraken, 2017-04-26 00:48:57]

LGTM

[haraken, 2017-04-26 00:49:01]

The CQ bit was checked by haraken@chromium.org

[commit-bot: I haz the power, 2017-04-26 00:49:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-26 00:49:34]

This CL has an open dependency (Issue 2840893002 Patch 40001). Please resolve
the dependency and try again.
If you are sure that there is no real dependency, please use one of the options
listed in https://goo.gl/9Es4OR to land the CL.

[jsbell, 2017-04-26 17:29:17]

The CQ bit was checked by jsbell@chromium.org

[commit-bot: I haz the power, 2017-04-26 17:29:43]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-26 17:53:04]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493227757322890,
"parent_rev": "3f43ee4706055a100b3a1c01ffc6f5585ef73828", "commit_rev":
"458671c24ea47bec9940f1db3034b711a78d5e8c"}

[commit-bot: I haz the power, 2017-04-26 17:53:16]

Description was changed from

==========
Indexed DB: Remove unnecessary defaults for optional args

Blink's bindings generation code didn't used to treat trailing
undefined parameters the same as missing for overload resolution. To
handle getAll(query, undefined) the same as getAll(query) - a
pattern used commonly in parameterized test cases - we specified a
default value for the second parameter in the IDL. That's no longer
necessary, and we can let the overload do that in the implementation.

(The bindings fix happened over a year ago but I missed it!)

R=haraken@chromium.org
BUG=335871
TEST=external/wpt/IndexedDB/idb*_getAll*.html
==========

to

==========
Indexed DB: Remove unnecessary defaults for optional args

Blink's bindings generation code didn't used to treat trailing
undefined parameters the same as missing for overload resolution. To
handle getAll(query, undefined) the same as getAll(query) - a
pattern used commonly in parameterized test cases - we specified a
default value for the second parameter in the IDL. That's no longer
necessary, and we can let the overload do that in the implementation.

(The bindings fix happened over a year ago but I missed it!)

R=haraken@chromium.org
BUG=335871
TEST=external/wpt/IndexedDB/idb*_getAll*.html

Review-Url: https://codereview.chromium.org/2837373002
Cr-Commit-Position: refs/heads/master@{#467375}
Committed:
https://chromium.googlesource.com/chromium/src/+/458671c24ea47bec9940f1db3034...
==========

[commit-bot: I haz the power, 2017-04-26 17:53:17]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/458671c24ea47bec9940f1db3034...