Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1464)

Issue 2840603002: Revert of Rework tab_capture_end2end_tests' test definition. (Closed)

Created:
3 years, 8 months ago by Dirk Pranke
Modified:
3 years, 8 months ago
CC:
chromium-reviews, jam, darin-cc_chromium.org, piman+watch_chromium.org, enne (OOO), Nico
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Rework tab_capture_end2end_tests' test definition. (patchset #2 id:40001 of https://codereview.chromium.org/2838473002/ ) Reason for revert: Reverting, tab_capture_end2end seems to be hanging a lot of tasks. Details to follow ... Original issue's description: > Rework tab_capture_end2end_tests' test definition. > > tab_capture_end2end_tests was previously defined as a target in > GN that depended on browser_tests, and as a target in the gn_isolate_map > as a "gpu_browser_test". In addition, the //testing/buildbot/ json > file generated by //content/test/gpu/generate_buildbot_json ended up > duplicating some of the logic that was in mb.py for handling > gpu_browser_tests. > > The fact that the logic was scattered over multiple places ended up > confusing `mb analyze`, with the result that if you were trying to > run both browser_tests and tab_capture_end2end_tests, you might only > get one of them. > > We need to reduce or eliminate the multiple different ways we have > of configuring test steps. Eventually we should push as much of this > logic as we can into the BUILD.gn files, I think, but for now if > we just move the concept of "tab_capture_end2end_tests" as a test > definition (i.e., something that only exists in the testing JSON > and as a filter file, the way site_per_process_browser_tests and > browser_side_navigation_browser_tests work today), things should > work correctly and we'll at least have one fewer way of configuring things. > > TBR=kbr@chromium.org > BUG=714336 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > > Review-Url: https://codereview.chromium.org/2838473002 > Cr-Commit-Position: refs/heads/master@{#466565} > Committed: https://chromium.googlesource.com/chromium/src/+/75636899ba7c25c8b3b632989e8358987a3b0b50 TBR=kbr@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=714336 Review-Url: https://codereview.chromium.org/2840603002 Cr-Commit-Position: refs/heads/master@{#466636} Committed: https://chromium.googlesource.com/chromium/src/+/eb27ad73c3ea58b8d878fa126490a3670ea98efe

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+226 lines, -282 lines) Patch
M chrome/test/BUILD.gn View 1 chunk +9 lines, -0 lines 0 comments Download
M content/test/gpu/generate_buildbot_json.py View 2 chunks +2 lines, -9 lines 0 comments Download
M testing/buildbot/chromium.gpu.json View 8 chunks +53 lines, -77 lines 0 comments Download
M testing/buildbot/chromium.gpu.fyi.json View 51 chunks +135 lines, -189 lines 0 comments Download
M testing/buildbot/filters/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D testing/buildbot/filters/tab-capture-end2end-tests.browser_tests.filter View 1 chunk +0 lines, -2 lines 0 comments Download
M testing/buildbot/gn_isolate_map.pyl View 2 chunks +8 lines, -0 lines 0 comments Download
M tools/mb/mb.py View 3 chunks +19 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Dirk Pranke
Created Revert of Rework tab_capture_end2end_tests' test definition.
3 years, 8 months ago (2017-04-24 16:03:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2840603002/1
3 years, 8 months ago (2017-04-24 16:04:11 UTC) #3
commit-bot: I haz the power
3 years, 8 months ago (2017-04-24 16:04:59 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/eb27ad73c3ea58b8d878fa126490...

Powered by Google App Engine
This is Rietveld 408576698