DescriptionRevert of Rework tab_capture_end2end_tests' test definition. (patchset #2 id:40001 of https://codereview.chromium.org/2838473002/ )
Reason for revert:
Reverting, tab_capture_end2end seems to be hanging a lot of tasks. Details to
follow ...
Original issue's description:
> Rework tab_capture_end2end_tests' test definition.
>
> tab_capture_end2end_tests was previously defined as a target in
> GN that depended on browser_tests, and as a target in the gn_isolate_map
> as a "gpu_browser_test". In addition, the //testing/buildbot/ json
> file generated by //content/test/gpu/generate_buildbot_json ended up
> duplicating some of the logic that was in mb.py for handling
> gpu_browser_tests.
>
> The fact that the logic was scattered over multiple places ended up
> confusing `mb analyze`, with the result that if you were trying to
> run both browser_tests and tab_capture_end2end_tests, you might only
> get one of them.
>
> We need to reduce or eliminate the multiple different ways we have
> of configuring test steps. Eventually we should push as much of this
> logic as we can into the BUILD.gn files, I think, but for now if
> we just move the concept of "tab_capture_end2end_tests" as a test
> definition (i.e., something that only exists in the testing JSON
> and as a filter file, the way site_per_process_browser_tests and
> browser_side_navigation_browser_tests work today), things should
> work correctly and we'll at least have one fewer way of configuring things.
>
> TBR=kbr@chromium.org
> BUG=714336
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
>
> Review-Url: https://codereview.chromium.org/2838473002
> Cr-Commit-Position: refs/heads/master@{#466565}
> Committed: https://chromium.googlesource.com/chromium/src/+/75636899ba7c25c8b3b632989e8358987a3b0b50
TBR=kbr@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=714336
Review-Url: https://codereview.chromium.org/2840603002
Cr-Commit-Position: refs/heads/master@{#466636}
Committed: https://chromium.googlesource.com/chromium/src/+/eb27ad73c3ea58b8d878fa126490a3670ea98efe
Patch Set 1 #
Messages
Total messages: 6 (3 generated)
|