Rework tab_capture_end2end_tests' test definition.

Rework tab_capture_end2end_tests' test definition.

tab_capture_end2end_tests was previously defined as a target in
GN that depended on browser_tests, and as a target in the gn_isolate_map
as a "gpu_browser_test". In addition, the //testing/buildbot/ json
file generated by //content/test/gpu/generate_buildbot_json ended up
duplicating some of the logic that was in mb.py for handling
gpu_browser_tests.

The fact that the logic was scattered over multiple places ended up
confusing `mb analyze`, with the result that if you were trying to
run both browser_tests and tab_capture_end2end_tests, you might only
get one of them.

We need to reduce or eliminate the multiple different ways we have
of configuring test steps. Eventually we should push as much of this
logic as we can into the BUILD.gn files, I think, but for now if
we just move the concept of "tab_capture_end2end_tests" as a test
definition (i.e., something that only exists in the testing JSON
and as a filter file, the way site_per_process_browser_tests and
browser_side_navigation_browser_tests work today), things should
work correctly and we'll at least have one fewer way of configuring things.

TBR=kbr@chromium.org
BUG=714336
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2838473002
Cr-Commit-Position: refs/heads/master@{#466565}
Committed: https://chromium.googlesource.com/chromium/src/+/75636899ba7c25c8b3b632989e8358987a3b0b50

[Dirk Pranke, 2017-04-23 02:19:23]

Description was changed from

==========
Rework tab_capture_end2end_tests' test definition.

tab_capture_end2end_tests was previously defined as a target in
GN that depended on browser_tests, and as a target in the gn_isolate_map
as a "gpu_browser_test". In addition, the //testing/buildbot/ json
file generated by //content/test/gpu/generate_buildbot_json ended up
duplicating some of the logic that was in mb.py for handling
gpu_browser_tests.

The fact that the logic was scattered over multiple places ended up
confusing `mb analyze`, with the result that if you were trying to
run both browser_tests and tab_capture_end2end_tests, you might only
get one of them.

We need to reduce or eliminate the multiple different ways we have
of configuring test steps. Eventually we should push as much of this
logic as we can into the BUILD.gn files, I think, but for now if
we just move the concept of "tab_capture_end2end_tests" as a test
definition (i.e., something that only exists in the testing JSON
and as a filter file, the way site_per_process_browser_tests and
browser_side_navigation_browser_tests work today), things should
work correctly and we'll at least have one fewer way of configuring things.

R=kbr@chromium.org
BUG=714336
==========

to

==========
Rework tab_capture_end2end_tests' test definition.

tab_capture_end2end_tests was previously defined as a target in
GN that depended on browser_tests, and as a target in the gn_isolate_map
as a "gpu_browser_test". In addition, the //testing/buildbot/ json
file generated by //content/test/gpu/generate_buildbot_json ended up
duplicating some of the logic that was in mb.py for handling
gpu_browser_tests.

The fact that the logic was scattered over multiple places ended up
confusing `mb analyze`, with the result that if you were trying to
run both browser_tests and tab_capture_end2end_tests, you might only
get one of them.

We need to reduce or eliminate the multiple different ways we have
of configuring test steps. Eventually we should push as much of this
logic as we can into the BUILD.gn files, I think, but for now if
we just move the concept of "tab_capture_end2end_tests" as a test
definition (i.e., something that only exists in the testing JSON
and as a filter file, the way site_per_process_browser_tests and
browser_side_navigation_browser_tests work today), things should
work correctly and we'll at least have one fewer way of configuring things.

R=kbr@chromium.org
BUG=714336
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Dirk Pranke, 2017-04-23 02:23:24]

Patchset #1 (id:1) has been deleted

[Dirk Pranke, 2017-04-23 02:24:52]

The CQ bit was checked by dpranke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-23 02:25:01]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dirk Pranke, 2017-04-23 02:25:50]

Description was changed from

==========
Rework tab_capture_end2end_tests' test definition.

tab_capture_end2end_tests was previously defined as a target in
GN that depended on browser_tests, and as a target in the gn_isolate_map
as a "gpu_browser_test". In addition, the //testing/buildbot/ json
file generated by //content/test/gpu/generate_buildbot_json ended up
duplicating some of the logic that was in mb.py for handling
gpu_browser_tests.

The fact that the logic was scattered over multiple places ended up
confusing `mb analyze`, with the result that if you were trying to
run both browser_tests and tab_capture_end2end_tests, you might only
get one of them.

We need to reduce or eliminate the multiple different ways we have
of configuring test steps. Eventually we should push as much of this
logic as we can into the BUILD.gn files, I think, but for now if
we just move the concept of "tab_capture_end2end_tests" as a test
definition (i.e., something that only exists in the testing JSON
and as a filter file, the way site_per_process_browser_tests and
browser_side_navigation_browser_tests work today), things should
work correctly and we'll at least have one fewer way of configuring things.

R=kbr@chromium.org
BUG=714336
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Rework tab_capture_end2end_tests' test definition.

tab_capture_end2end_tests was previously defined as a target in
GN that depended on browser_tests, and as a target in the gn_isolate_map
as a "gpu_browser_test". In addition, the //testing/buildbot/ json
file generated by //content/test/gpu/generate_buildbot_json ended up
duplicating some of the logic that was in mb.py for handling
gpu_browser_tests.

The fact that the logic was scattered over multiple places ended up
confusing `mb analyze`, with the result that if you were trying to
run both browser_tests and tab_capture_end2end_tests, you might only
get one of them.

We need to reduce or eliminate the multiple different ways we have
of configuring test steps. Eventually we should push as much of this
logic as we can into the BUILD.gn files, I think, but for now if
we just move the concept of "tab_capture_end2end_tests" as a test
definition (i.e., something that only exists in the testing JSON
and as a filter file, the way site_per_process_browser_tests and
browser_side_navigation_browser_tests work today), things should
work correctly and we'll at least have one fewer way of configuring things.

R=kbr@chromium.org
BUG=714336
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Dirk Pranke, 2017-04-23 02:27:22]

https://codereview.chromium.org/2838473002/diff/20001/testing/buildbot/chromi...
File testing/buildbot/chromium.gpu.json (right):

https://codereview.chromium.org/2838473002/diff/20001/testing/buildbot/chromi...
testing/buildbot/chromium.gpu.json:354: "test": "browser_tests",
Here and in chromium.gpu.fyi.json, the diffs will be a bit confusing because the
entries are sorted by 'test', not 'name', and so this moves the tab_capture
entry up near the front and everything else ends up off-by-one.

[commit-bot: I haz the power, 2017-04-23 03:07:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-23 03:07:26]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Dirk Pranke, 2017-04-23 03:23:56]

The CQ bit was checked by dpranke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-23 03:24:06]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-23 04:23:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-23 04:23:56]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Dirk Pranke, 2017-04-23 15:55:22]

The CQ bit was checked by dpranke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-23 15:55:26]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-23 16:32:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-23 16:32:30]

Dry run: This issue passed the CQ dry run.

[Dirk Pranke, 2017-04-23 16:36:02]

Description was changed from

==========
Rework tab_capture_end2end_tests' test definition.

tab_capture_end2end_tests was previously defined as a target in
GN that depended on browser_tests, and as a target in the gn_isolate_map
as a "gpu_browser_test". In addition, the //testing/buildbot/ json
file generated by //content/test/gpu/generate_buildbot_json ended up
duplicating some of the logic that was in mb.py for handling
gpu_browser_tests.

The fact that the logic was scattered over multiple places ended up
confusing `mb analyze`, with the result that if you were trying to
run both browser_tests and tab_capture_end2end_tests, you might only
get one of them.

We need to reduce or eliminate the multiple different ways we have
of configuring test steps. Eventually we should push as much of this
logic as we can into the BUILD.gn files, I think, but for now if
we just move the concept of "tab_capture_end2end_tests" as a test
definition (i.e., something that only exists in the testing JSON
and as a filter file, the way site_per_process_browser_tests and
browser_side_navigation_browser_tests work today), things should
work correctly and we'll at least have one fewer way of configuring things.

R=kbr@chromium.org
BUG=714336
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Rework tab_capture_end2end_tests' test definition.

tab_capture_end2end_tests was previously defined as a target in
GN that depended on browser_tests, and as a target in the gn_isolate_map
as a "gpu_browser_test". In addition, the //testing/buildbot/ json
file generated by //content/test/gpu/generate_buildbot_json ended up
duplicating some of the logic that was in mb.py for handling
gpu_browser_tests.

The fact that the logic was scattered over multiple places ended up
confusing `mb analyze`, with the result that if you were trying to
run both browser_tests and tab_capture_end2end_tests, you might only
get one of them.

We need to reduce or eliminate the multiple different ways we have
of configuring test steps. Eventually we should push as much of this
logic as we can into the BUILD.gn files, I think, but for now if
we just move the concept of "tab_capture_end2end_tests" as a test
definition (i.e., something that only exists in the testing JSON
and as a filter file, the way site_per_process_browser_tests and
browser_side_navigation_browser_tests work today), things should
work correctly and we'll at least have one fewer way of configuring things.

TBR=kbr@chromium.org
BUG=714336
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Dirk Pranke, 2017-04-23 16:36:34]

I think I'll go ahead and land this so that browser_tests will be run correctly
again. It's easy to revert if need be.

[Dirk Pranke, 2017-04-23 16:36:38]

The CQ bit was checked by dpranke@chromium.org

[commit-bot: I haz the power, 2017-04-23 16:36:49]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-23 16:42:28]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1492965398843070,
"parent_rev": "fa550e2af24a576a19bb3f3c74987a50680c541d", "commit_rev":
"75636899ba7c25c8b3b632989e8358987a3b0b50"}

[commit-bot: I haz the power, 2017-04-23 16:42:40]

Description was changed from

==========
Rework tab_capture_end2end_tests' test definition.

tab_capture_end2end_tests was previously defined as a target in
GN that depended on browser_tests, and as a target in the gn_isolate_map
as a "gpu_browser_test". In addition, the //testing/buildbot/ json
file generated by //content/test/gpu/generate_buildbot_json ended up
duplicating some of the logic that was in mb.py for handling
gpu_browser_tests.

The fact that the logic was scattered over multiple places ended up
confusing `mb analyze`, with the result that if you were trying to
run both browser_tests and tab_capture_end2end_tests, you might only
get one of them.

We need to reduce or eliminate the multiple different ways we have
of configuring test steps. Eventually we should push as much of this
logic as we can into the BUILD.gn files, I think, but for now if
we just move the concept of "tab_capture_end2end_tests" as a test
definition (i.e., something that only exists in the testing JSON
and as a filter file, the way site_per_process_browser_tests and
browser_side_navigation_browser_tests work today), things should
work correctly and we'll at least have one fewer way of configuring things.

TBR=kbr@chromium.org
BUG=714336
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Rework tab_capture_end2end_tests' test definition.

tab_capture_end2end_tests was previously defined as a target in
GN that depended on browser_tests, and as a target in the gn_isolate_map
as a "gpu_browser_test". In addition, the //testing/buildbot/ json
file generated by //content/test/gpu/generate_buildbot_json ended up
duplicating some of the logic that was in mb.py for handling
gpu_browser_tests.

The fact that the logic was scattered over multiple places ended up
confusing `mb analyze`, with the result that if you were trying to
run both browser_tests and tab_capture_end2end_tests, you might only
get one of them.

We need to reduce or eliminate the multiple different ways we have
of configuring test steps. Eventually we should push as much of this
logic as we can into the BUILD.gn files, I think, but for now if
we just move the concept of "tab_capture_end2end_tests" as a test
definition (i.e., something that only exists in the testing JSON
and as a filter file, the way site_per_process_browser_tests and
browser_side_navigation_browser_tests work today), things should
work correctly and we'll at least have one fewer way of configuring things.

TBR=kbr@chromium.org
BUG=714336
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2838473002
Cr-Commit-Position: refs/heads/master@{#466565}
Committed:
https://chromium.googlesource.com/chromium/src/+/75636899ba7c25c8b3b632989e83...
==========

[commit-bot: I haz the power, 2017-04-23 16:42:41]

Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/75636899ba7c25c8b3b632989e83...

[Dirk Pranke, 2017-04-24 16:02:58]

On 2017/04/23 16:42:41, commit-bot: I haz the power wrote:
> Committed patchset #2 (id:40001) as
>
https://chromium.googlesource.com/chromium/src/+/75636899ba7c25c8b3b632989e83...

Reverting, tab_capture_end2end seems to be hanging a lot of tasks. Details to
follow ...

[Dirk Pranke, 2017-04-24 16:03:28]

A revert of this CL (patchset #2 id:40001) has been created in
https://codereview.chromium.org/2840603002/ by dpranke@chromium.org.

The reason for reverting is: Reverting, tab_capture_end2end seems to be hanging
a lot of tasks. Details to
follow ....