Allow IO thread usage in WebRTC browsertests

Allow IO thread usage in WebRTC browsertests

BUG=684680
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2840333004
Cr-Commit-Position: refs/heads/master@{#467577}
Committed: https://chromium.googlesource.com/chromium/src/+/e93ca496c5603e318d78d77da78d48741536d65e

[emircan, 2017-04-27 00:56:06]

The CQ bit was checked by emircan@chromium.org to run a CQ dry run

[emircan, 2017-04-27 00:56:15]

emircan@chromium.org changed reviewers:
+ jam@chromium.org

[emircan, 2017-04-27 00:56:15]

PTAL.

[commit-bot: I haz the power, 2017-04-27 00:56:30]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[emircan, 2017-04-27 00:56:30]

Description was changed from

==========
Allow IO thread  usage in WebRTC browsertests

BUG=684680
==========

to

==========
Allow IO thread usage in WebRTC browsertests

BUG=684680
==========

[jam, 2017-04-27 01:06:41]

lgtm with removing presubmit change and os_mac ifdefs

https://codereview.chromium.org/2840333004/diff/1/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.chromium.org/2840333004/diff/1/PRESUBMIT.py#newcode206
PRESUBMIT.py:206:
r"^chrome[\\\/]browser[\\\/]lifetime[\\\/]application_lifetime\.cc$",
no need for editing this, just add
NOPRESUBMIT=true
in the cl description

https://codereview.chromium.org/2840333004/diff/1/chrome/browser/media/webrtc...
File chrome/browser/media/webrtc/webrtc_apprtc_browsertest.cc (right):

https://codereview.chromium.org/2840333004/diff/1/chrome/browser/media/webrtc...
chrome/browser/media/webrtc/webrtc_apprtc_browsertest.cc:28: #if
defined(OS_MACOSX)
nit: no need to ifdef this

https://codereview.chromium.org/2840333004/diff/1/chrome/browser/media/webrtc...
chrome/browser/media/webrtc/webrtc_apprtc_browsertest.cc:240: #if
defined(OS_MACOSX)
I'm a bit surprised that this code and other tests is only asserting on mac
since this should be cross platform?

perhaps remove the ifdef since it's ok to run this on other platforms as well?

[emircan, 2017-04-27 01:15:43]

Description was changed from

==========
Allow IO thread usage in WebRTC browsertests

BUG=684680
==========

to

==========
Allow IO thread usage in WebRTC browsertests

BUG=684680
NOPRESUBMIT=true
==========

[emircan, 2017-04-27 01:26:38]

The CQ bit was checked by emircan@chromium.org to run a CQ dry run

[emircan, 2017-04-27 01:26:47]

https://codereview.chromium.org/2840333004/diff/1/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.chromium.org/2840333004/diff/1/PRESUBMIT.py#newcode206
PRESUBMIT.py:206:
r"^chrome[\\\/]browser[\\\/]lifetime[\\\/]application_lifetime\.cc$",
On 2017/04/27 01:06:41, jam wrote:
> no need for editing this, just add
> NOPRESUBMIT=true
> in the cl description

Done.

https://codereview.chromium.org/2840333004/diff/1/chrome/browser/media/webrtc...
File chrome/browser/media/webrtc/webrtc_apprtc_browsertest.cc (right):

https://codereview.chromium.org/2840333004/diff/1/chrome/browser/media/webrtc...
chrome/browser/media/webrtc/webrtc_apprtc_browsertest.cc:28: #if
defined(OS_MACOSX)
On 2017/04/27 01:06:41, jam wrote:
> nit: no need to ifdef this

Done.

https://codereview.chromium.org/2840333004/diff/1/chrome/browser/media/webrtc...
chrome/browser/media/webrtc/webrtc_apprtc_browsertest.cc:240: #if
defined(OS_MACOSX)
On 2017/04/27 01:06:41, jam wrote:
> I'm a bit surprised that this code and other tests is only asserting on mac
> since this should be cross platform?
> 
> perhaps remove the ifdef since it's ok to run this on other platforms as well?

Done. It turns out that win is also using this:
https://build.chromium.org/p/chromium.webrtc/builders/Win10%20Tester/builds/1...

[commit-bot: I haz the power, 2017-04-27 01:27:32]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[emircan, 2017-04-27 01:34:14]

The CQ bit was unchecked by emircan@chromium.org

[emircan, 2017-04-27 01:34:18]

The CQ bit was checked by emircan@chromium.org

[emircan, 2017-04-27 01:34:18]

The patchset sent to the CQ was uploaded after l-g-t-m from jam@chromium.org
Link to the patchset: https://codereview.chromium.org/2840333004/#ps20001
(title: "jam@ comments.")

[commit-bot: I haz the power, 2017-04-27 01:34:49]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-27 04:19:03]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493256858251330,
"parent_rev": "15eb928d886a49c90111f25af454be9df4fba3a7", "commit_rev":
"e93ca496c5603e318d78d77da78d48741536d65e"}

[commit-bot: I haz the power, 2017-04-27 04:19:33]

Description was changed from

==========
Allow IO thread usage in WebRTC browsertests

BUG=684680
NOPRESUBMIT=true
==========

to

==========
Allow IO thread usage in WebRTC browsertests

BUG=684680
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2840333004
Cr-Commit-Position: refs/heads/master@{#467577}
Committed:
https://chromium.googlesource.com/chromium/src/+/e93ca496c5603e318d78d77da78d...
==========

[commit-bot: I haz the power, 2017-04-27 04:19:34]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/e93ca496c5603e318d78d77da78d...