Allow IO thread usage in WebRTC browsertests

chrome/browser/media/webrtc/webrtc_apprtc_browsertest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/command_line.h"
 #include "base/files/file_enumerator.h"
 #include "base/path_service.h"
 #include "base/process/launch.h"
 #include "base/rand_util.h"
 #include "build/build_config.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/infobars/infobar_responder.h"
 #include "chrome/browser/infobars/infobar_service.h"
 #include "chrome/browser/media/webrtc/webrtc_browsertest_base.h"
 #include "chrome/browser/media/webrtc/webrtc_browsertest_common.h"
 #include "chrome/browser/permissions/permission_request_manager.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_tabstrip.h"
 #include "chrome/browser/ui/tabs/tab_strip_model.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/test/base/ui_test_utils.h"
 #include "content/public/common/content_switches.h"
 #include "content/public/test/browser_test_utils.h"
 #include "media/base/media_switches.h"
 #include "net/test/python_utils.h"
 #include "ui/gl/gl_switches.h"
 
+#if defined(OS_MACOSX)

[jam, 2017/04/27 01:06:41]

nit: no need to ifdef this

[emircan, 2017/04/27 01:26:47]

Done.

+#include "base/threading/thread_restrictions.h"
+#endif  // defined(OS_MACOSX)
+
 const char kTitlePageOfAppEngineAdminPage[] = "Instances";
 
 const char kIsApprtcCallUpJavascript[] =
     "var remoteVideo = document.querySelector('#remote-video');"
     "var remoteVideoActive ="
     "    remoteVideo != null &&"
     "    remoteVideo.classList.contains('active');"
     "window.domAutomationController.send(remoteVideoActive.toString());";
 
 
@@ skipping 187 matching lines @@
     return firefox_.IsValid();
   }
 
  private:
   base::Process dev_appserver_;
   base::Process firefox_;
   base::Process collider_server_;
 };
 
 IN_PROC_BROWSER_TEST_F(WebRtcApprtcBrowserTest, MANUAL_WorksOnApprtc) {
+// crbug.com/684680
+#if defined(OS_MACOSX)

[jam, 2017/04/27 01:06:41]

I'm a bit surprised that this code and other tests is only asserting on mac
since this should be cross platform?

perhaps remove the ifdef since it's ok to run this on other platforms as well?

[emircan, 2017/04/27 01:26:47]

Done. It turns out that win is also using this:
https://build.chromium.org/p/chromium.webrtc/builders/Win10%20Tester/builds/1...

+  base::ThreadRestrictions::ScopedAllowIO allow_io;
+#endif  // defined(OS_MACOSX)
   DetectErrorsInJavaScript();
   ASSERT_TRUE(LaunchApprtcInstanceOnLocalhost("9999"));
   ASSERT_TRUE(LaunchColliderOnLocalHost("http://localhost:9999", "8089"));
   while (!LocalApprtcInstanceIsUp())
     DVLOG(1) << "Waiting for AppRTC to come up...";
 
   GURL room_url = GURL("http://localhost:9999/r/some_room"
                        "?wshpp=localhost:8089&wstls=false");
 
   // Set up the left tab.
@@ skipping 53 matching lines @@
       InfoBarService::FromWebContents(chrome_tab), InfoBarResponder::ACCEPT);
   ui_test_utils::NavigateToURL(browser(), room_url);
 
   ASSERT_TRUE(LaunchFirefoxWithUrl(room_url));
 
   ASSERT_TRUE(WaitForCallToComeUp(chrome_tab));
 
   // Ensure Firefox manages to send video our way.
   ASSERT_TRUE(DetectRemoteVideoPlaying(chrome_tab));
 }