Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Side by Side Diff: PRESUBMIT.py

Issue 2840333004: Allow IO thread usage in WebRTC browsertests (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Top-level presubmit script for Chromium. 5 """Top-level presubmit script for Chromium.
6 6
7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
8 for more details about the presubmit API built into depot_tools. 8 for more details about the presubmit API built into depot_tools.
9 """ 9 """
10 10
(...skipping 183 matching lines...) Expand 10 before | Expand all | Expand 10 after
194 'New code should not use ScopedAllowIO. Post a task to the blocking', 194 'New code should not use ScopedAllowIO. Post a task to the blocking',
195 'pool or the FILE thread instead.', 195 'pool or the FILE thread instead.',
196 ), 196 ),
197 True, 197 True,
198 ( 198 (
199 r"^base[\\\/]memory[\\\/]shared_memory_posix\.cc$", 199 r"^base[\\\/]memory[\\\/]shared_memory_posix\.cc$",
200 r"^base[\\\/]process[\\\/]internal_aix\.cc$", 200 r"^base[\\\/]process[\\\/]internal_aix\.cc$",
201 r"^base[\\\/]process[\\\/]process_linux\.cc$", 201 r"^base[\\\/]process[\\\/]process_linux\.cc$",
202 r"^base[\\\/]process[\\\/]process_metrics_linux\.cc$", 202 r"^base[\\\/]process[\\\/]process_metrics_linux\.cc$",
203 r"^chrome[\\\/]browser[\\\/]chromeos[\\\/]boot_times_recorder\.cc$", 203 r"^chrome[\\\/]browser[\\\/]chromeos[\\\/]boot_times_recorder\.cc$",
204 r"^chrome[\\\/]browser[\\\/]lifetime[\\\/]application_lifetime\.cc$",
205 r"^chrome[\\\/]browser[\\\/]chromeos[\\\/]" 204 r"^chrome[\\\/]browser[\\\/]chromeos[\\\/]"
206 "customization_document_browsertest\.cc$", 205 "customization_document_browsertest\.cc$",
206 r"^chrome[\\\/]browser[\\\/]lifetime[\\\/]application_lifetime\.cc$",
jam 2017/04/27 01:06:41 no need for editing this, just add NOPRESUBMIT=tru
emircan 2017/04/27 01:26:47 Done.
207 r"^chrome[\\\/]browser[\\\/]media[\\\/]webrtc[\\\/]"
208 "webrtc_apprtc_browsertest\.cc$",
209 r"^chrome[\\\/]browser[\\\/]media[\\\/]webrtc[\\\/]"
210 "webrtc_audio_quality_browsertest\.cc$",
211 r"^chrome[\\\/]browser[\\\/]media[\\\/]webrtc[\\\/]"
212 "webrtc_internals_perf_browsertest\.cc$",
213 r"^chrome[\\\/]browser[\\\/]media[\\\/]webrtc[\\\/]"
214 "webrtc_stats_perf_browsertest\.cc$",
215 r"^chrome[\\\/]browser[\\\/]media[\\\/]webrtc[\\\/]"
216 "webrtc_video_quality_browsertest\.cc$",
207 r"^components[\\\/]crash[\\\/]app[\\\/]breakpad_mac\.mm$", 217 r"^components[\\\/]crash[\\\/]app[\\\/]breakpad_mac\.mm$",
208 r"^content[\\\/]shell[\\\/]browser[\\\/]layout_test[\\\/]" + 218 r"^content[\\\/]shell[\\\/]browser[\\\/]layout_test[\\\/]" +
209 r"test_info_extractor\.cc$", 219 r"test_info_extractor\.cc$",
210 r"^content[\\\/].*browser(|_)test[a-zA-Z_]*\.cc$", 220 r"^content[\\\/].*browser(|_)test[a-zA-Z_]*\.cc$",
211 r"^content[\\\/]shell[\\\/]browser[\\\/]shell_browser_main\.cc$", 221 r"^content[\\\/]shell[\\\/]browser[\\\/]shell_browser_main\.cc$",
212 r"^content[\\\/]shell[\\\/]browser[\\\/]shell_message_filter\.cc$", 222 r"^content[\\\/]shell[\\\/]browser[\\\/]shell_message_filter\.cc$",
213 r"^content[\\\/]test[\\\/]ppapi[\\\/]ppapi_test\.cc$", 223 r"^content[\\\/]test[\\\/]ppapi[\\\/]ppapi_test\.cc$",
214 r"^mojo[\\\/]edk[\\\/]embedder[\\\/]" + 224 r"^mojo[\\\/]edk[\\\/]embedder[\\\/]" +
215 r"simple_platform_shared_buffer_posix\.cc$", 225 r"simple_platform_shared_buffer_posix\.cc$",
216 r"^net[\\\/]disk_cache[\\\/]cache_util\.cc$", 226 r"^net[\\\/]disk_cache[\\\/]cache_util\.cc$",
(...skipping 2235 matching lines...) Expand 10 before | Expand all | Expand 10 after
2452 output_api, 2462 output_api,
2453 json_url='http://chromium-status.appspot.com/current?format=json')) 2463 json_url='http://chromium-status.appspot.com/current?format=json'))
2454 2464
2455 results.extend( 2465 results.extend(
2456 input_api.canned_checks.CheckPatchFormatted(input_api, output_api)) 2466 input_api.canned_checks.CheckPatchFormatted(input_api, output_api))
2457 results.extend(input_api.canned_checks.CheckChangeHasBugField( 2467 results.extend(input_api.canned_checks.CheckChangeHasBugField(
2458 input_api, output_api)) 2468 input_api, output_api))
2459 results.extend(input_api.canned_checks.CheckChangeHasDescription( 2469 results.extend(input_api.canned_checks.CheckChangeHasDescription(
2460 input_api, output_api)) 2470 input_api, output_api))
2461 return results 2471 return results
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698